PR/57172 CVS commit: src

[gnats-admin%netbsd.org@localhost]

The following reply was made to PR lib/57172; it has been noted by GNATS.

From: "David H. Gutteridge" <gutteridge%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/57172 CVS commit: src
Date: Wed, 21 Aug 2024 16:30:27 +0000

 Module Name:	src
 Committed By:	gutteridge
 Date:		Wed Aug 21 16:30:27 UTC 2024
 
 Modified Files:
 	src/sys/sys: syslog.h
 	src/usr.sbin/syslogd: syslogd.c
 
 Log Message:
 syslog.h & syslogd.c: avoid incorrect facility double-shifting
 
 As discussed in PR lib/57172, don't double-shift facility values when
 calculating logging contexts. Patch suggested by RVP, an approach also
 consistent with what OpenBSD did, which is to simply remove LOG_MAKEPRI
 and adjust the only place it's used in the tree. (This has the benefit
 of exposing any third-party software that may have also been using the
 incorrect value all this time.)
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.43 -r1.44 src/sys/sys/syslog.h
 cvs rdiff -u -r1.142 -r1.143 src/usr.sbin/syslogd/syslogd.c
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.