Re: PR/57807 CVS commit: src/sys/sys

[Rin Okuyama <rokuyama.rk%gmail.com@localhost>]

On amd64 host with this commit for endian.h, cross-build for
evbarmv7hf-eb (at least) fails as follows:

````
% uname -a
NetBSD sakaizumii.local 10.99.12 NetBSD 10.99.12 (AMD64_NET_MPSAFE) #0: 
Sun Sep 22 10:03:08 JST 2024 
rin@sakaizumii.local:/home/rin/src/sys/arch/amd64/compile/AMD64_NET_MPSAFE 
amd64
% head -1 /usr/include/sys/endian.h
/*      $NetBSD: endian.h,v 1.35 2024/09/09 18:38:38 rillig Exp $       */
% cd src/tools/libctf && nbmake-evbarmv7hf-eb
...
In file included from 
/home/rin/build.pullup-0925/tools/include/compat/nbtool_config.h:931,
                 from 
/home/rin/src/tools/libctf/../../external/cddl/osnet/dist/
common/ctf/ctf_create.c:23:
/home/rin/src/tools/libctf/../compat/compat_defs.h:1148:22: error: 
redefinition of 'be16enc'
...
````

This can be worked around by reverting rev 1.34 only.

The failure occurs because:
(1) During configure in tools/compat, _NETBSD_SOURCE is disabled.
(2) For other tools build, _NETBSD_SOURCE is defined.

Thoughts?

Thanks,
rin

On 2024/09/10 3:20, Taylor R Campbell wrote:
> The following reply was made to PR standards/57807; it has been noted by GNATS.
>
> From: "Taylor R Campbell" <riastradh%netbsd.org@localhost>
> To: gnats-bugs%gnats.NetBSD.org@localhost
> Cc:
> Subject: PR/57807 CVS commit: src/sys/sys
> Date: Mon, 9 Sep 2024 18:17:14 +0000
>
>   Module Name:	src
>   Committed By:	riastradh
>   Date:		Mon Sep  9 18:17:14 UTC 2024
>   
>   Modified Files:
>   	src/sys/sys: endian.h
>   
>   Log Message:
>   sys/endian.h: Hide le32enc/be32enc/... under _NETBSD_SOURCE.
>   
>   These are non-standard extensions, so they should not be exposed by,
>   e.g., _XOPEN_SOURCE=700.
>   
>   PR standards/57807: #include <arpa/inet.h> spuriously defines
>   le32enc/be32enc/... under _XOPEN_SOURCE=700
>   
>   
>   To generate a diff of this commit:
>   cvs rdiff -u -r1.33 -r1.34 src/sys/sys/endian.h
>   
>   Please note that diffs are not public domain; they are subject to the
>   copyright notices on the relevant files.
>