Re: PR/57807 CVS commit: src/sys/sys

["Robert Elz via gnats" <gnats-admin%NetBSD.org@localhost>]

The following reply was made to PR standards/57807; it has been noted by GNATS.

From: Robert Elz <kre%munnari.OZ.AU@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: PR/57807 CVS commit: src/sys/sys
Date: Wed, 25 Sep 2024 14:33:07 +0700

     Date:        Wed, 25 Sep 2024 06:30:04 +0000 (UTC)
     From:        "Rin Okuyama via gnats" <gnats-admin%NetBSD.org@localhost>
     Message-ID:  <20240925063004.798201A923D%mollari.NetBSD.org@localhost>
 
   |  The failure occurs because:
   |  (1) During configure in tools/compat, _NETBSD_SOURCE is disabled.
   |  (2) For other tools build, _NETBSD_SOURCE is defined.
   |  
   |  Thoughts?
 
 Ideally, _NETBSD_SOURCE wouldn't be defined at all for tools builds.
 That it is resulted in the gross hack to fix the gmake tools build
 (only ever built as a tool).   I haven't looked, but something similar
 might work in this case as well, but making _NETBSD_SOURCE not be
 the default would be a much better solution.
 
 That could be done by simply doing the tools builds with one of the
 other feature macros defined, but which one?  (and what value?)
 
 So an easier way might just be to define a new macro like _NO_NETBSD_SOURCE
 that <sys/featuretest.h>  could use to avoid defining _NETBSD_SOURCE
 when nothing else is defined, without committing to one of the others.
 
 kre