PR/58674 CVS commit: src/usr.bin/mkubootimage

["David H. Gutteridge" <gutteridge%netbsd.org@localhost>]

The following reply was made to PR lib/58674; it has been noted by GNATS.

From: "David H. Gutteridge" <gutteridge%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/58674 CVS commit: src/usr.bin/mkubootimage
Date: Tue, 29 Oct 2024 02:54:38 +0000

 Module Name:	src
 Committed By:	gutteridge
 Date:		Tue Oct 29 02:54:38 UTC 2024
 
 Modified Files:
 	src/usr.bin/mkubootimage: mkubootimage.c
 
 Log Message:
 mkubootimage.c: consistently use endian.h origin functions
 
 Since this already uses bswap32(3), le64toh(3), etc., switch to also
 use htobe32(3) and be32toh(3) instead of htonl(3) and ntohl(3). This
 seems the best way to fix build breakages under recent Linux distros
 where GCC objects to missing prototypes (since otherwise we'd need to
 include arpa/inet.h, which wasn't declared). Another issue related to
 PR lib/58674.
 
 Confirmed this fixes builds on Fedora 40 (since all these functions are
 provided by NetBSD compat). No changes noted to resulting installation
 images generated for armv7hf on a NetBSD build.
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.33 -r1.34 src/usr.bin/mkubootimage/mkubootimage.c
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.