PR/58787 CVS commit: [netbsd-10] src

["Martin Husemann" <martin%netbsd.org@localhost>]

The following reply was made to PR bin/58787; it has been noted by GNATS.

From: "Martin Husemann" <martin%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/58787 CVS commit: [netbsd-10] src
Date: Mon, 18 Nov 2024 19:42:41 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Mon Nov 18 19:42:41 UTC 2024
 
 Modified Files:
 	src/lib/libtelnet [netbsd-10]: enc-proto.h enc_des.c encrypt.c
 	    encrypt.h
 	src/libexec/telnetd [netbsd-10]: state.c sys_term.c telnetd.c
 
 Log Message:
 Pull up following revision(s) (requested by riastradh in ticket #1013):
 
 	lib/libtelnet/encrypt.h: revision 1.10
 	libexec/telnetd/telnetd.c: revision 1.59
 	libexec/telnetd/sys_term.c: revision 1.50
 	lib/libtelnet/encrypt.c: revision 1.20
 	lib/libtelnet/enc_des.c: revision 1.18
 	lib/libtelnet/enc-proto.h: revision 1.11
 	libexec/telnetd/state.c: revision 1.33
 	libexec/telnetd/state.c: revision 1.35
 	libexec/telnetd/telnetd.c: revision 1.60
 
 Fix memory leak - free resources allocated by getaddrinfo
 
 Fix off by one in telrcv()
 
 In case of "\r" in the data buffer, the code was unconditionally looking ahead
 to next character, even if "\r" was last character in the buffer. That
 condition leads to read outside of the data (one byte after the array)
 Thanks christos@ for the review
 PR bin/58787  libtelnet - avoid using a global variable
 
 From RVP -- make 'encrypt_debug_mode' be a static (file scope)
 variable instead of extern, and convert the (had been recently
 anyway) unused function encrypt_debug() into an accensor function
 for it.
 
 This is the minor (almost irrelevant) change from PR bin/58787
 PR bin/58787  telnetd - handle auto authentication better
 Apparently from FreeBSD via RVP -- but FreeBSD deleted telnetd
 more than 2 years ago, so I assume instead from
 
         https://github.com/cschuber/freebsd-telnet/tree/main/contrib/telnet
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.10 -r1.10.10.1 src/lib/libtelnet/enc-proto.h
 cvs rdiff -u -r1.16 -r1.16.42.1 src/lib/libtelnet/enc_des.c
 cvs rdiff -u -r1.19 -r1.19.2.1 src/lib/libtelnet/encrypt.c
 cvs rdiff -u -r1.9 -r1.9.50.1 src/lib/libtelnet/encrypt.h
 cvs rdiff -u -r1.32 -r1.32.2.1 src/libexec/telnetd/state.c
 cvs rdiff -u -r1.49 -r1.49.8.1 src/libexec/telnetd/sys_term.c
 cvs rdiff -u -r1.58 -r1.58.2.1 src/libexec/telnetd/telnetd.c
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.