bin/58851: wg-keygen(8) needs tests, abuses libssh

[campbell+netbsd%mumble.net@localhost]

>Number:         58851
>Category:       bin
>Synopsis:       wg-keygen(8) needs tests, abuses libssh
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Nov 24 15:10:00 +0000 2024
>Originator:     Taylor R Campbell
>Release:        current, 10
>Organization:
The libNetWG-keygen Foundation
>Environment:
>Description:
1. wg-keygen (no arguments) should have a randomized property test of the fixed bits.
2. wg-keygen --pub is a deterministic function which needs known-answer tests.  (Plain wg-keygen and wg-keygen --psk should maybe also have seed-determinized tests.)
3. wg-keygen grabs its X25519 scalarmult routine (crypto_scalarmult_curve25519) from libssh, which it really shouldn't; libssh is an unstable private library of openssh.  We should either get it from OpenSSL, or maybe reachover into the kernel libsodium code.
>How-To-Repeat:
code inspection
>Fix:
Yes, please!