PR/58829 CVS commit: [netbsd-10] src

["Martin Husemann" <martin%netbsd.org@localhost>]

The following reply was made to PR lib/58829; it has been noted by GNATS.

From: "Martin Husemann" <martin%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/58829 CVS commit: [netbsd-10] src
Date: Tue, 26 Nov 2024 09:44:37 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Tue Nov 26 09:44:36 UTC 2024
 
 Modified Files:
 	src/external/bsd/libarchive/lib/libarchive [netbsd-10]: Makefile
 	src/tests/lib/libarchive [netbsd-10]: Makefile
 
 Log Message:
 Pull up following revision(s) (requested by riastradh in ticket #1017):
 
 	external/bsd/libarchive/lib/libarchive/Makefile: revision 1.20
 	tests/lib/libarchive/Makefile: revision 1.16
 
 libarchive: Export only public symbols.
 
 1. Build with -fvisibility=hidden -D__LIBARCHIVE_ENABLE_VISIBILITY,
    which is upstream's supported way to export only public symbols.
    => Verified that this only suppresses symbols which are _not_
       declared in libarchive's public header files.
 
 2. Link with -Wl,--exclude-libs,libzstd so that statically linked
    libzstd symbols aren't exported.
    => Verified that this only suppresses libzstd symbols which are not
       part of libarchive at all.
 
 This deletes exported symbols from a shared library -- but only those
 that should never have been exported to begin with, and that can't be
 used by normal libarchive applications without going out of their way
 to get at internal symbols.  In fact, some of these symbols, like
 blake2s_init, are likely to collide with other libraries or
 applications.
 
 So while this technically violates the letter of shlib major rules
 and releng pullup rules by deleting exported symbols, I'm not bumping
 and I intend to pull this up to 10 (and maybe 9) -- because I suspect
 it is more likely that libarchive's private symbols will conflict
 with other uses in real applications than that real applications will
 rely on libarchive's private symbols.
 PR lib/58829: libarchive exports excess symbols
 
 tests/lib/libarchive: Link against libarchive statically.
 The tests reach into libarchive guts, so they don't work with only
 the public symbols, which are all that libarchive.so exports now.
 
 PR lib/58829: libarchive exports excess symbols
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.14.2.3 -r1.14.2.4 \
     src/external/bsd/libarchive/lib/libarchive/Makefile
 cvs rdiff -u -r1.5.6.3 -r1.5.6.4 src/tests/lib/libarchive/Makefile
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.