PR/58674 CVS commit: [netbsd-10] src

["Martin Husemann" <martin%netbsd.org@localhost>]

The following reply was made to PR lib/58674; it has been noted by GNATS.

From: "Martin Husemann" <martin%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/58674 CVS commit: [netbsd-10] src
Date: Sun, 15 Dec 2024 12:57:33 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Sun Dec 15 12:57:33 UTC 2024
 
 Modified Files:
 	src/sys/arch/hppa/stand/mkboot [netbsd-10]: mkboot.c
 	src/sys/arch/powerpc/stand/mkbootimage [netbsd-10]: mkbootimage.c
 	src/usr.bin/elf2aout [netbsd-10]: elf2aout.c
 
 Log Message:
 Pull up following revision(s) (requested by gutteridge in ticket #1019):
 
 	sys/arch/hppa/stand/mkboot/mkboot.c: revision 1.5
 	sys/arch/powerpc/stand/mkbootimage/mkbootimage.c: revision 1.21
 	usr.bin/elf2aout/elf2aout.c: revision 1.25
 
 mkboot.c: ensure all functions are declared
 
 Addresses build failure issue on current Linux distros that have a GCC
 with implicit-function-declaration baked in as an error. Use be32toh(3)
 instead of ntohl(3), seems to make more sense stylistically. Build
 tested on Fedora 40.
 
 Issue reported by Jan-Benedict Glaw. Also relevant to PR lib/58674.
 
 elf2aout.c: switch to use htobe32(3)
 
 As discussed on tech-toolchain. Tested with virt68k tools build on
 Fedora 40. (Relevant to PR lib/58674.)
 
 mkbootimage.c: consistently use sa_htobe32(2)
 
 There were 38 calls to sa_htobe32(2) and two to htonl(3), mixed even
 within the same function, with arpa/inet.h not included. (It's unclear
 why this varied, as the original version of this file first checked in
 included this discrepancy.)
 
 Addresses build failure issue on current Linux distros that have a GCC
 with implicit-function-declaration baked in as an error. Build tested
 on Fedora 40.
 
 Issue reported by Jan-Benedict Glaw. Also relevant to PR lib/58674.
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.2 -r1.2.48.1 src/sys/arch/hppa/stand/mkboot/mkboot.c
 cvs rdiff -u -r1.19 -r1.19.48.1 \
     src/sys/arch/powerpc/stand/mkbootimage/mkbootimage.c
 cvs rdiff -u -r1.23.10.1 -r1.23.10.2 src/usr.bin/elf2aout/elf2aout.c
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.