PR/58837 CVS commit: [netbsd-10] src/sys/ufs

["Martin Husemann" <martin%netbsd.org@localhost>]

The following reply was made to PR kern/58837; it has been noted by GNATS.

From: "Martin Husemann" <martin%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/58837 CVS commit: [netbsd-10] src/sys/ufs
Date: Tue, 7 Jan 2025 16:13:35 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Tue Jan  7 16:13:35 UTC 2025
 
 Modified Files:
 	src/sys/ufs/ext2fs [netbsd-10]: ext2fs_vfsops.c
 	src/sys/ufs/ffs [netbsd-10]: ffs_vfsops.c ffs_wapbl.c
 	src/sys/ufs/lfs [netbsd-10]: lfs_vfsops.c
 
 Log Message:
 Pull up following revision(s) (requested by hannken in ticket #1037):
 
 	sys/ufs/ext2fs/ext2fs_vfsops.c: revision 1.228
 	sys/ufs/lfs/lfs_vfsops.c: revision 1.383
 	sys/ufs/ffs/ffs_wapbl.c: revision 1.50
 	sys/ufs/ffs/ffs_vfsops.c: revision 1.383
 	sys/ufs/ffs/ffs_vfsops.c: revision 1.384
 
 Remove comment "we are always called with the filesystem marked `MPBUSY'."
 above some xxx_sync() operations.  These operations get called without
 any exclusive lock.
 
 This comment appeared with "add quota support" on 1990-05-02.
 On 1998/02/18 MNT_MPBUSY disappeared when vfs_busy() was changed from
 an exclusive lock to a shared lock.
 
 PR kern/58837 "ffs: Missing locking around fs_fmod/time"
 
 Protect test/clear fs->fs_fmod with um_lock like it is already
 protected in ffs_alloc.c.
 
 When writing to disk protect moving superblock to buffer with um_lock.
 
 Set/clear fs->fmod while mounting, updating a mount or unmounting
 is safe as these operations run exclusive, either mounting creates
 a new file system or the file system is suspended.  Assert suspension
 for update and unmount.
 
 PR kern/58837 "ffs: Missing locking around fs_fmod/time"
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.221 -r1.221.4.1 src/sys/ufs/ext2fs/ext2fs_vfsops.c
 cvs rdiff -u -r1.378.2.3 -r1.378.2.4 src/sys/ufs/ffs/ffs_vfsops.c
 cvs rdiff -u -r1.48 -r1.48.4.1 src/sys/ufs/ffs/ffs_wapbl.c
 cvs rdiff -u -r1.382 -r1.382.4.1 src/sys/ufs/lfs/lfs_vfsops.c
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.