Re: lib/58282: Sysinst terminal output size increased because curses

["Andreas Gustafsson via gnats" <gnats-admin%NetBSD.org@localhost>]

The following reply was made to PR lib/58282; it has been noted by GNATS.

From: Andreas Gustafsson <gson%gson.org@localhost>
To: Brett Lymn <blymn%internode.on.net@localhost>
Cc: gnats-bugs%netbsd.org@localhost,
    lib-bug-people%netbsd.org@localhost
Subject: Re: lib/58282: Sysinst terminal output size increased because curses
Date: Thu, 13 Feb 2025 18:03:52 +0200

 Brett Lymn wrote:
 > Hi Andreas.  Can you please try the attached patch?  This should fix the
 > excessive output from sysinst.
 
 Thanks, this does improve things a great deal overall.
 
 One remaining oddity is that when sysinst starts and clears the
 screen, it appears to do it three times, first sending 24 copies of
 ^[[K^M, then 24 copies of ^[[C^[[K^M, and finally 24 copies of ^[[K^M
 again.  But maybe that's just sysinst calling curses in strange ways
 rather than a problem with curses itself.
 
 Also, the patch is making the drawing of the boxes around the sysinst
 menus slower than it was before.  Without the patch, the horizontal
 lines above and below the menu are drawn by switching to the line
 drawing character set once, then outputting multiple line drawing
 characters, and finally switching back to ASCII.  With the patch, it
 switches back and forth between the line drawing character set and
 ASCII for every line drawing character printed.
 
 Here is an updated set of links to the terminal output from different
 versions.  The columns on the right are the total file size (including
 things like qemu messages and kernel boot messages) and the remaining
 size after removing the parts prior to sysinst starting.
 
   https://www.gson.org/netbsd/bugs/curses/2022.04.11.21.23.07-install.log              74365     52813
   https://www.gson.org/netbsd/bugs/curses/2022.04.12.07.03.29-install.log             164936    143386
   https://www.gson.org/netbsd/bugs/curses/2024.07.06.11.09.17-install.log             250499    157326
   https://www.gson.org/netbsd/bugs/curses/2024.07.06.11.09.17-install-patched.log     226238    137345
   https://www.gson.org/netbsd/bugs/curses/2025.02.12.05.15.39-install.log             230676    137377
   https://www.gson.org/netbsd/bugs/curses/2025.02.12.05.15.39-install-patched.log     144771     55694
 
 -- 
 Andreas Gustafsson, gson%gson.org@localhost