Re: kern/59153: crash dump doesn't dump

["Michael van Elst via gnats" <gnats-admin%NetBSD.org@localhost>]

The following reply was made to PR kern/59153; it has been noted by GNATS.

From: mlelstv%serpens.de@localhost (Michael van Elst)
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: kern/59153: crash dump doesn't dump
Date: Sat, 8 Mar 2025 00:26:23 -0000 (UTC)

 paul%whooppee.com@localhost writes:
 
 >[     1.658122] ld0: GPT GUID: 4ebed702-001b-41b4-8b42-2d8886317b60
 >...
 >[     1.701091] dk6 at ld0: "NVME-dump", 629145600 blocks at 2411726848, type: swap
 >...
 >[   229.000000] dump [   1.0000000] Copyright (c) 1996, 1997, 1998, 1999, 2000, 2001, 2002, 2003,
 
 Maybe lucky that it didn't dump.
 
 While the dump interface works with daddr_t block addresses, the ld(4)
 backend works with 'int'.
 
 The partition starts at 2411726848, which, as an 'int' is a negative
 value, that gets interpreted as a daddr_t (sign extended) again.
 
 static int
 ld_nvme_dump(struct ld_softc *ld, void *data, int blkno, int blkcnt)
 {
         struct ld_nvme_softc *sc = device_private(ld->sc_dv);
 
         return nvme_ns_dobio(sc->sc_nvme, sc->sc_nsid, sc,
             NULL, data, blkcnt * ld->sc_secsize,
             sc->sc_ld.sc_secsize, blkno,
             NVME_NS_CTX_F_POLL,
             ld_nvme_biodone);
 }