bin/59222: Build failure on Solaris-11.4 for src/sbin/newfs_udf/udf_core.c

[cryintothebluesky%gmail.com@localhost]

>Number:         59222
>Category:       bin
>Synopsis:       Build failure on Solaris-11.4 for src/sbin/newfs_udf/udf_core.c
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Mar 26 17:25:00 +0000 2025
>Originator:     Sad Clouds
>Release:        NetBSD-10
>Organization:
>Environment:
SunOS t4-node1 5.11 11.4.42.111.0 sun4v sparc sun4v non-virtualized

>Description:
Building NetBSD-10 with build.sh fails:

/opt/netbsd/netbsd-10-src/sbin/newfs_udf/udf_core.c:717:51: error: 'NAME_MAX' undeclared (first use in this function)
  717 |                 assert(strlen((char *) (id+1)) <= NAME_MAX);
      |

Solaris does not define NAME_MAX and this macro is not portable. This may need #ifdef logic.
>How-To-Repeat:

>Fix:
diff -u src/sbin/newfs_udf/udf_core.c.orig src/sbin/newfs_udf/udf_core.c
--- src/sbin/newfs_udf/udf_core.c.orig  2025-03-26 08:46:46.591168084 +0000
+++ src/sbin/newfs_udf/udf_core.c       2025-03-26 15:09:53.582379006 +0000
@@ -714,7 +714,7 @@
        } else {
                /* assume 8bit char length byte latin-1 */
                assert(*id == 8);
-               assert(strlen((char *) (id+1)) <= NAME_MAX);
+               assert(strlen((char *) (id+1)) <= MAXNAMLEN);
                memcpy((char *) result, (char *) (id+1), strlen((char *) (id+1)));
        }
        free(raw_name);