misc/59226: Build failure on Solaris-11.4 in src/share/mk/bsd.test.mk

[cryintothebluesky%gmail.com@localhost]

>Number:         59226
>Category:       misc
>Synopsis:       Build failure on Solaris-11.4 in src/share/mk/bsd.test.mk
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    misc-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Mar 27 08:25:01 +0000 2025
>Originator:     Sad Clouds
>Release:        NetBSD-10
>Organization:
>Environment:
SunOS t4-node1 5.11 11.4.42.111.0 sun4v sparc sun4v non-virtualized
>Description:
#    create  libi386/Atffile
sh[3]: syntax error at line 3 : `;' unexpected

*** Failed target: Atffile
*** Failed commands:
        ${_MKTARGET_CREATE}
        => @echo '#  ' " create " libi386/Atffile
        @{ echo 'Content-Type: application/X-atf-atffile; version="1"';  echo;  echo '# Automatically generated by bsd.test.mk.';  echo;  echo 'prop: test-suite = "NetBSD"';  echo;  for tp in ${TESTS_SUBDIRS:N.WAIT} ${_TESTS} ${ATFFILE_EXTRA_SUBDIRS};  do  echo "tp: $${tp}";  done; } >Atffile.tmp
        => @{ echo 'Content-Type: application/X-atf-atffile; version="1"';  echo;  echo '# Automatically generated by bsd.test.mk.';  echo;  echo 'prop: test-suite = "NetBSD"';  echo;  for tp in   ;  do  echo "tp: ${tp}";  done; } >Atffile.tmp
        @${MV} Atffile.tmp Atffile
        => @mv -f Atffile.tmp Atffile
*** [Atffile] Error code 2

nbmake[8]: stopped in /opt/netbsd/netbsd-10-src/tests/lib/libi386


The error is coming from src/share/mk/bsd.test.mk on this line:

for tp in ${TESTS_SUBDIRS:N.WAIT} ${_TESTS} ${ATFFILE_EXTRA_SUBDIRS};

all variables seem to expand to empty strings, which makes the for construct invalid.

I wonder if this is something to do with parallel make. Maybe the Makefile is run before required variables are defined correctly?
>How-To-Repeat:

>Fix: