bin/59244: lint: spurious complaint: constant in conditional context

[campbell+netbsd%mumble.net@localhost]

>Number:         59244
>Category:       bin
>Synopsis:       lint: spurious complaint: constant in conditional context
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Mar 31 23:55:01 +0000 2025
>Originator:     Taylor R Campbell
>Release:        current
>Organization:
The LintBSD Prediction
>Environment:
>Description:
/home/riastradh/netbsd/current/src/lib/libc/../../common/lib/libc/hash/murmurhash/murmurhash.c(56): warning: constant in conditional context [161]

    56		if (__predict_true(ALIGNED_POINTER(key, uint32_t))) {

https://nxr.netbsd.org/xref/src/common/lib/libc/hash/murmurhash/murmurhash.c?r=1.8#56

This is probably a consequence of the recent change to the definition of __predict_true:

-#define        __predict_true(exp)     __builtin_expect((exp) != 0, 1)
+#define        __predict_true(exp)     __builtin_expect((exp) ? 1 : 0, 1)

But I don't think any of this code is wrong or even objectionable style as written.  This seems like a spurious warning from lint.
>How-To-Repeat:
cd lib/libc && make lint
>Fix:
Yes, please!