misc/59300: The InvalidBSD Timertestation

[campbell+netbsd%mumble.net@localhost]

>Number:         59300
>Category:       misc
>Synopsis:       The InvalidBSD Timertestation
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    misc-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Apr 16 01:25:00 +0000 2025
>Originator:     Taylor R Campbell
>Release:        current, maybe 10 or 9 if pulled up
>Organization:
campbell+netbsd%mumble.net@localhost
>Environment:
>Description:
The t_timer_create:timer_invalidtime and t_timerfd:timerfd_invalidtime tests are failing on riscv and alpha:

https://releng.netbsd.org/b5reports/riscv-riscv64/2025/2025.04.14.16.43.01/test.html#lib_libc_sys_t_timer_create_timer_invalidtime
https://releng.netbsd.org/b5reports/alpha/2025/2025.04.15.10.10.36/test.html#lib_libc_sys_t_timer_create_timer_invalidtime

On review of the tests, it looks like they rely on uninitialized data -- and possibly just don't make sense at all for some cases because -1 + now.tv_sec + 60 is likely to be a valid number of seconds in the future anyway:

    445 		struct itimerspec its;
    446 
    447 		fprintf(stderr, "case %u\n", i);
    448 
    449 		ATF_CHECK_ERRNO(EINVAL,
    450 		    timer_settime(t, 0, &einval_its[i], NULL) == -1);
    451 
    452 		/* Try the same with an absolute time near now. */
    453 		its.it_value = einval_its[i].it_value;
    454 		its.it_value.tv_sec += now.tv_sec + 60;
    455 		ATF_CHECK_ERRNO(EINVAL,
    456 		    timer_settime(t, TIMER_ABSTIME, &its, NULL) == -1);
>How-To-Repeat:
cd /usr/tests/lib/libc/sys
atf-run t_timer_create t_timerfd | atf-report
>Fix:
Yes, please!