NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

PR/59327 CVS commit: src/tests/kernel/arch/mips



The following reply was made to PR kern/59327; it has been noted by GNATS.

From: "Taylor R Campbell" <riastradh%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/59327 CVS commit: src/tests/kernel/arch/mips
Date: Sun, 27 Apr 2025 16:49:55 +0000

 Module Name:	src
 Committed By:	riastradh
 Date:		Sun Apr 27 16:49:54 UTC 2025
 
 Modified Files:
 	src/tests/kernel/arch/mips: contextspfunc.S execsp.S signalsphandler.S
 
 Log Message:
 t_signal_and_sp: Try to fix mips o32 tests.
 
 Evidently, for o32, PIC_PROLOGUE (which expands to .cpload) must be
 the very first instruction of the function, or else it will get the
 $gp calculation wrong.
 
 Since it seems that the mips PIC_PROLOGUE does not, after all, mess
 with the stack, let's just dispense with the temporary copy of sp in
 t0 which I had added in paranoia over what magic might happen inside
 PIC_PROLOGUE.  (Such paranoia is not entirely unjustified -- for
 example, the sh3 PIC_PROLOGUE _does_ push data on the stack, though
 this can be bypassed with PIC_PROLOGUE_NOSAVE.)
 
 PR kern/59327: user stack pointer is not aligned properly
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.1 -r1.2 src/tests/kernel/arch/mips/contextspfunc.S \
     src/tests/kernel/arch/mips/execsp.S \
     src/tests/kernel/arch/mips/signalsphandler.S
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.
 


Home | Main Index | Thread Index | Old Index