fdisk MSDOS partitions too large = not mountable

[Stephen Borrill <netbsd%precedence.co.uk@localhost>]

I'm seeing a number of makes and models of camera that have dodgy fdisk 
partition structure. The size of the FAT partition is the same as the 
whole disk, but the start offset is 1. On NetBSD 3, this is mountable, but 
with NetBSD 4 and later, the filesystem will not be mounted.

Is the check really necessary with a FAT filesystem (clearly Windows, etc. 
is happy with this)?

server 1# fdisk sd0
Disk: /dev/rsd0d
NetBSD disklabel disk geometry:
cylinders: 1956, heads: 64, sectors/track: 32 (2048 sectors/cylinder)
total sectors: 4006928

BIOS disk geometry:
cylinders: 249, heads: 255, sectors/track: 63 (16065 sectors/cylinder)
total sectors: 4006928

Partition table:
0: Primary 'big' DOS, 16-bit FAT (> 32MB) (sysid 6)
    start 1, size 4006928 (1957 MB, Cyls 0/0/2-249/107/4), Active
1: <UNUSED>
2: <UNUSED>
3: <UNUSED>

This gets passed through to disklabel, of course:

server 2# disklabel sd0
# /dev/rsd0d:
type: SCSI
disk: mydisk
label: fictitious
flags:
bytes/sector: 512
sectors/track: 32
tracks/cylinder: 64
sectors/cylinder: 2048
cylinders: 1956
total sectors: 4006928
rpm: 3600
interleave: 1
trackskew: 0
cylinderskew: 0
headswitch: 0           # microseconds
track-to-track seek: 0  # microseconds
drivedata: 0

5 partitions:
#        size    offset     fstype [fsize bsize cpg/sgs]
 d:   4006928         0     unused      0     0        # (Cyl.      0 - 
1956*)
 e:   4006928         1      MSDOS                     # (Cyl.      0*- 
1956+)
disklabel: boot block size 0
disklabel: super block size 0
disklabel: partition e: partition extends past end of unit

--
Stephen