NetBSD-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: postinstall bug in mtree check?



"J. Lewis Muir" <jlmuir%imca-cat.org@localhost> writes:

> Adding '-s' to the make invocation in postinstall fixes the problem.
> Below is a patch against the netbsd-6 CVS branch.
>
> Thanks,
>
> Lewis
>
> Index: usr.sbin/postinstall/postinstall
> ===================================================================
> RCS file: /cvsroot/src/usr.sbin/postinstall/postinstall,v
> retrieving revision 1.129.2.11
> diff -u -r1.129.2.11 postinstall
> --- usr.sbin/postinstall/postinstall	21 May 2014 20:29:02 -0000	1.129.2.11
> +++ usr.sbin/postinstall/postinstall	24 Sep 2014 20:57:20 -0000
> @@ -998,7 +998,7 @@
>  	if ! $SOURCEMODE; then
>  		MTREE_DIR="${SRC_DIR}/etc/mtree"
>  	else
> -		${MAKE} -C ${SRC_DIR}/etc/mtree emit_dist_file > \
> +		${MAKE} -s -C ${SRC_DIR}/etc/mtree emit_dist_file > \
>  		    "${SCRATCHDIR}/NetBSD.dist"
>  		MTREE_DIR="${SCRATCHDIR}"
>  	fi

There's already a fix in -current and -7, which is to put @ in front of
the cat command in the makefile.   I've asked that this  be pulled up to
netbsd-6:
  http://releng.netbsd.org/cgi-bin/req-6.cgi?show=1163

Thanks for the report - without it none of us would have realized that
this fix was both needed and missing in -6!

Greg

Attachment: pgpbs6EVYKp7t.pgp
Description: PGP signature



Home | Main Index | Thread Index | Old Index