NetBSD-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: netbsd crashes when using fat filesys



On Thu 02 May 2024 at 20:10:10 -0000, Michael van Elst wrote:
> rhialto%falu.nl@localhost (Rhialto) writes:
> 
> >I had something similar recently when doing a rename of a file on a FAT
> >file system (in this case my /efi file system). Fortunately I had it
> >mounted with -o rump, because it was 100% repeatable.
> 
> >I filed http://gnats.netbsd.org/58146 for it.
> 
> 
> Maybe that's rump.
> 
> msdosfs:
>         KASSERT(tcnp->cn_cred == cred);
> 
> genfs:  /*
>          * XXX Want a better equality test.  `tcnp->cn_cred == cred'
>          * hoses p2k because puffs transmits the creds separately and
>          * allocates distinct but equivalent structures for them.
>          */
>         KASSERT(kauth_cred_uidmatch(cred, tcnp->cn_cred));
> 
> 
> Can you still repeat the crash when you change the assertion
> to match the genfs check ?

Unless I did something wrong with rebuilding rump_msdos, the problem still
exists when using that assertion instead. But the message from the assertion
failure now goes into the void. (Although that somehow also happens if I
use the original rump_msdos executable)

Here is how I tested (I used a file system in a file this time rather
than the real partition):

terminal 1:

$ ls -l efi.img  rump_msdos
-rw-r--r--  1 rhialto  wheel  134217728 May  2 22:32 efi.img
-r-xr-xr-x  1 rhialto  wheel      20776 May  2 22:29 rump_msdos*
$ sudo ./rump_msdos -o rw -o rump ./efi.img /tmp/t
rump_msdos: "./efi.img" is a relative path.
rump_msdos: using "/mnt/scratch/scratch/tmp/xcrash/efi.img" instead.
[   1.0000000] entropy: ready

terminal 2:

$ cd /tmp/t
$ ls -l
total 4
drwxr-xr-x  1 rhialto  wheel  4096 Apr 21  2021 efi/
-rwxr-xr-x  1 rhialto  wheel     0 May  2 22:32 file*
$ mv file file2
mv: rename file to file2: Device not configured
$ ls -l
ls: .: No such file or directory

-Olaf.
-- 
___ Olaf 'Rhialto' Seibert                            <rhialto/at/falu.nl>
\X/ There is no AI. There is just someone else's work.           --I. Rose

Attachment: signature.asc
Description: PGP signature



Home | Main Index | Thread Index | Old Index