pkg/26524: print/gv build fails on -current

[jbernard%mines.edu@localhost]

>Number:         26524
>Category:       pkg
>Synopsis:       print/gv build fails on -current
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Aug 03 00:20:00 UTC 2004
>Closed-Date:
>Last-Modified:
>Originator:     Jim Bernard
>Release:        NetBSD 2.0G, pkgsrc of Mon Aug  2 09:35:30 UTC 2004
>Organization:
>Environment:
System: NetBSD 2.0G Sat Jul 31 17:03:53 MDT 2004 i386
Architecture: i386
Machine: i386
>Description:
        print/gv fails to build because it isn't linked against Xaw3d:

        ...
        gcc -o gv -O2 -fno-strict-aliasing      -L/usr/pkg/lib  
-L/usr/X11R6/lib  Aaa.o Aaa_bison.o Aaa_lex.o Button.o Clip.o FileSel.o Frame.o 
Ghostview.o MButton.o Switch.o Vlist.o actions.o callbacks.o confirm.o dialog.o 
doc_misc.o error.o file.o info.o magmenu.o main.o media.o misc.o miscmenu.o 
misc_private.o note.o options.o options_fs.o options_gs.o options_gv.o 
options_setup.o process.o popup.o ps.o resource.o save.o scale.o signal.o 
version.o widgets_misc.o zoom.o      Scrollbar.o           -L/usr/X11R6/lib   
-lm /usr/X11R6/lib/libXaw.a -lXmu -lXt -lSM -lICE -lXpm -lXext -lX11            
     -Wl,-rpath,/usr/pkg/lib:/usr/X11R6/lib
        Scrollbar.o(.data+0x380): undefined reference to `threeDClassRec'
        *** Error code 1

        Stop.

        (BTW: the link failure occurs even with /etc/mk.conf removed.)

        An example of a link step that succeeds is:

        gcc -o gv -O2 -fno-strict-aliasing      -L/usr/pkg/lib  
-L/usr/X11R6/lib  Aaa.o Aaa_bison.o Aaa_lex.o Button.o Clip.o FileSel.o Frame.o 
Ghostview.o MButton.o Switch.o Vlist.o actions.o callbacks.o confirm.o dialog.o 
doc_misc.o error.o file.o info.o magmenu.o main.o media.o misc.o miscmenu.o 
misc_private.o note.o options.o options_fs.o options_gs.o options_gv.o 
options_setup.o process.o popup.o ps.o resource.o save.o scale.o signal.o 
version.o widgets_misc.o zoom.o      Scrollbar.o           -L/usr/X11R6/lib   
-lm -lXaw3d -lXmu -lXt -lSM -lICE -lXpm -lXext -lX11                 
-Wl,-rpath,/usr/pkg/lib:/usr/X11R6/lib

>How-To-Repeat:
        Try to build it.

>Fix:
        The problem was introduced by this piece of rev. 1.9 of patch-aa:

         XCOMM --- The name of the Xaw3d library.
         XCOMM 
--------------------------------------------------------------------
         XCOMM XAWLIB = -lXaw
        -      XAWLIB = -lXaw3d
        +      XAWLIB = ${LIBXAW}

        I don't yet see why it doesn't work correctly as is (LIBXAW is
        set by x11/Xaw3d/buildlink3.mk, which should be called by
        mk/xaw.buildlink3.mk when XAW_TYPE is set to 3d, which occurs
        in the gv Makefile), but reverting that part of rev. 1.9 makes
        the build succeed.  I consider this to be a workaround, since
        it seems like the actual breakage must lie elsewhere.
>Release-Note:
>Audit-Trail:
>Unformatted: