pkg/26668: graphics/vtk-data and graphics/vtk-docs cannot find distfiles

[kre%munnari.OZ.AU@localhost]

>Number:         26668
>Category:       pkg
>Synopsis:       graphics/vtk-data and graphics/vtk-docs cannot find distfiles
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Aug 15 14:56:00 UTC 2004
>Closed-Date:
>Last-Modified:
>Originator:     Robert Elz
>Release:        NetBSD 1.6X (--- pkgsrc current as of date/time of this 
>message)
>Organization:
        Prince of Songkla University
>Environment:
System: NetBSD jade.coe.psu.ac.th 1.6X NetBSD 1.6X (JADE) #17: Wed Sep 24 
20:25:35 ICT 2003 
kre%jade.coe.psu.ac.th@localhost:/usr/src/real-sys/arch/i386/compile/JADE i386
Architecture: i386
Machine: i386
>Description:
        No distfile can be fetched for graphics/vtk-data or
        graphics/vtk-docs (just one PR for both as they're caused
        by a common problem, that needs fixing only once).

        This is because neither of these packages has MASTER_SITES
        set - leaving them to try just MASTER_SITES_BACKUP - none
        of which can have he distfiles, as they only ever try to
        fetch from each other...

>How-To-Repeat:
        rm .../distfiles/VTKData-4.2.tar.gz .../distfiles/VTKDocHtml-4.2.tar.gz
        ## you may want to move them instead

        cd .../pkgsrc/graphics/vtk-data
        make fetch

        cd .../pkgsrc/graphics/vtk-docs
        make fetch

        Observe that the various netbsd (& freebsd) backup sites
        are used as sources for the distfiles, but none have them.

        Nowhere is sourceforge used, which does have the distfiles.
>Fix:
        Apply the patch below.

        **** Note that this patch is to the graphics/vtk package ***
                                            ============

        This moves the definition of MASTER_SITES from Makefile.vtkdist
        (which is used by graphics/vtk and graphics/vtk-python)
        into Makefile.common (which is used by all 4 vtk packages).

        Does anyone ever actually test any of this stuff ??
        (FWIW the pkgsrc-wip version of this package, last year, "worked"
        fine ("worked" for me means "distfile fetched and verified"))

Index: Makefile.common
===================================================================
RCS file: /cvsroot/pkgsrc/graphics/vtk/Makefile.common,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 Makefile.common
--- Makefile.common     2 Aug 2004 13:13:40 -0000       1.1.1.1
+++ Makefile.common     15 Aug 2004 14:43:51 -0000
@@ -5,3 +5,5 @@
 CATEGORIES=            graphics
 MAINTAINER=            dotz%irc.pl@localhost
 HOMEPAGE=              http://www.vtk.org/
+
+MASTER_SITES=          ${MASTER_SITE_SOURCEFORGE:=vtk/}
Index: Makefile.vtkdist
===================================================================
RCS file: /cvsroot/pkgsrc/graphics/vtk/Makefile.vtkdist,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 Makefile.vtkdist
--- Makefile.vtkdist    2 Aug 2004 13:13:40 -0000       1.1.1.1
+++ Makefile.vtkdist    15 Aug 2004 14:43:51 -0000
@@ -8,8 +8,6 @@
 DIST_SUBDIR=           VTK-4.2.6
 WRKSRC=                ${WRKDIR}/VTK
 
-MASTER_SITES=          ${MASTER_SITE_SOURCEFORGE:=vtk/}
-
 DISTINFO_FILE=         ${.CURDIR}/../vtk/distinfo
 PATCHDIR=              ${.CURDIR}/../vtk/patches
 
>Release-Note:
>Audit-Trail:
>Unformatted: