pkg/27540: MOZILLA_USE_GTK2 in /etc/mk.conf ignored

[dan%uboat.geek.com.au@localhost]

>Number:         27540
>Category:       pkg
>Synopsis:       MOZILLA_USE_GTK2 in /etc/mk.conf ignored
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Oct 27 06:18:00 UTC 2004
>Closed-Date:
>Last-Modified:
>Originator:     Daniel Carosone
>Release:        NetBSD 2.99.10
>Organization:
>Environment:
System: NetBSD uboat 2.99.10 NetBSD 2.99.10 (_uboat_) #214: Wed Oct 27 14:30:55 
EST 2004 
dan@uboat:/home/NetBSD/obj/p3/home/NetBSD/HEAD/src/sys/arch/i386/compile/_uboat_
 i386
Architecture: i386
Machine: i386
>Description:

For a long time, I have built www/mozilla with GTK2.  Rather than
using the www/mozilla-gtk2 pseudo-pkg, I just have MOZILLA_USE_GTK2
(and _XFT) in mk.conf

I do this because I don't want all the other renaming tweakery the
-gtk2 pseudo-pkg does, and don't care that gtk1 and gtk2 versions of
mozilla can't coincide.

Recently, something changed and these variables are not obeyed anymore
by Makefile.common; they have to come from the pkg-specfici Makefile
wrapper, or the command-line.

dan@uboat [16:02][59]/usr/pkgsrc/www/mozilla> make show-vars VARNAMES=DEPENDS
 freetype2>=2.1.9nb1:../../graphics/freetype2 jpeg>=6bnb2:../../graphics/jpeg 
png>=1.2.6nb1:../../graphics/png 
gdk-pixbuf>=0.22.0nb3:../../graphics/gdk-pixbuf 
ORBit>=0.5.15nb7:../../net/ORBit gtk+>=1.2.10nb8:../../x11/gtk 
Xft2>=2.1.6nb1:../../fonts/Xft2
dan@uboat [16:02][60]/usr/pkgsrc/www/mozilla> make show-vars VARNAMES=DEPENDS 
MOZILLA_USE_GTK2=YES 
 freetype2>=2.1.9nb1:../../graphics/freetype2 jpeg>=6bnb2:../../graphics/jpeg 
png>=1.2.6nb1:../../graphics/png libIDL>=0.8.4nb1:../../net/libIDL 
gtk2+>=2.4.10nb1:../../x11/gtk2 Xft2>=2.1.6nb1:../../fonts/Xft2
dan@uboat [16:02][61]/usr/pkgsrc/www/mozilla> make show-vars 
VARNAMES=MOZILLA_USE_GTK2
YES

This regression is annoying because this has worked right for some
time.  I'm also worried about what *else* from mk.conf isn't getting
set for mozilla.

>How-To-Repeat:
        
>Fix:
pull in bsd.prefs.mk at an earlier stage of Makefile.common?
>Release-Note:
>Audit-Trail:
>Unformatted: