pkg/28805: mail/qpopper's IPv6 patch introduces compile time error on IPv4-only system.

[georg.schwarz%freenet.de@localhost]

>Number:         28805
>Category:       pkg
>Synopsis:       mail/qpopper's IPv6 patch introduces compile time error on 
>IPv4-only system.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Dec 29 21:33:00 +0000 2004
>Originator:     Georg Schwarz
>Release:        current pkgsrc
>Organization:
>Environment:
IRIX lorenz 5.3 08031225 IP20 mips
>Description:
ftp://ftp.kame.net/pub/kame/misc/qpopper-4.0.5-ipv6-20030313.diff.gz, which is 
applied by mail/qpopper, has the following lines (for patching popper/
main.c):

...
+#ifndef INET6
         unsigned long  a = addr;
+        unsigned short n = ntohs ( port );
         unsigned short n = port;
         char           b [ 25 ] = "";
+#endif
...

this leads to n being defined twice and thus the compilation to fail.

>How-To-Repeat:
compile mail/qpopper without IPv6 support.

>Fix:
I would assume that the developers of the patch forgot to cancel out the 
original line (unsigned short n = port;). So a quick fix might be just to patch 
it away with an additional pkgsrc patch to popper/main.c (it is being patched 
anyway for other things).
On the longer run, it would be probably better to correct the IPV6 patch. Does 
anyone know how to report this to its author(s)?