Re: pkg/28230: bsd.pkg.mk ignores /etc/audit-packages.conf

[Alistair Crooks <agc%pkgsrc.org@localhost>]

The following reply was made to PR pkg/28230; it has been noted by GNATS.

From: Alistair Crooks <agc%pkgsrc.org@localhost>
To: "Julio M. Merino Vidal" <jmmv84%gmail.com@localhost>
Cc: Hauke Fath <hauke%Espresso.Rhein-Neckar.DE@localhost>,
        gnats-bugs%netbsd.org@localhost
Subject: Re: pkg/28230: bsd.pkg.mk ignores /etc/audit-packages.conf
Date: Thu, 31 Mar 2005 22:03:14 +0100

 On Wed, Mar 23, 2005 at 11:02:04PM +0100, Julio M. Merino Vidal wrote:
 > On Wed, 2005-03-23 at 21:14 +0000, Alistair Crooks wrote:
 > > On Wed, Nov 17, 2004 at 08:15:40PM +0100, Hauke Fath wrote:
 > > > Julio M. Merino Vidal wrote
 > > > 
 > > > [Note that I saw this only by chance / because of the duplicate of this
 > > > bug; you left me off the Cc: list.]
 > > > 
 > > > > How does the patch below look?  (I've put the chunk of code just 
 > > > > before the
 > > > > check-vulnerable target, but I'm not sure that's the best place...)
 > > > [...]
 > > > 
 > > > Works for me (although I must admit it looks a bit clumsy to me).
 > > 
 > > Thanks to Julio
 > 
 > You're welcome.
 > 
 > >  - I wonder if the attached patch is any more
 > > aesthetically pleasing?
 > 
 > I don't think we need to do the 'X' compatibility hack in the tests.
 > It looks like you'd use -z "${VAR}" instead (after all, we're already
 > using that construction in several other places).
 
 Thanks, I've committed this now.
 
 Regards,
 Alistair