pkg/29894: pkg_create does not enough error checking

[roland.illig%gmx.de@localhost]

>Number:         29894
>Category:       pkg
>Synopsis:       pkg_create does not enough error checking
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Apr 05 16:03:00 +0000 2005
>Originator:     roland.illig%gmx.de@localhost
>Release:        All
>Organization:
        
>Environment:
        
        
System: NetBSD baccf5ee.roland-illig.de 2.99.15 NetBSD 2.99.15 (GENERIC) #0: 
Wed Feb 9 20:19:30 CET 2005 
build%baccf5ee.roland-illig.de@localhost:/home/build/objroot/sys/arch/i386/compile/GENERIC
 i386
Architecture: i386
Machine: i386
>Description:

when creating the +CONTENTS file for a package, pkg_create calls the
fprintf() function various times without checking if the function
succeeded. This can lead to unnoticed package corruption. In my case,
editors/abiword could not be packaged, and the "make package" process
terminated without giving an error message.

>How-To-Repeat:
        
>Fix:
        
Add _complete_ error checking to the pkgtools/pkg_install program.
Enable lint(1) for it.

>Unformatted: