pkg/30438: cdrdao not writing

[b1ff%fr33.b33r.net@localhost]

>Number:         30438
>Category:       pkg
>Synopsis:       cdrdao not writing
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Jun 06 02:44:00 +0000 2005
>Originator:     Mathieu
>Release:        
>Organization:
>Environment:
NetBSD sal.lan 2.0.2_STABLE NetBSD 2.0.2_STABLE (SPECIFIC) #0: Sun Apr 10 
01:32:33 EDT 2005  
mathieu%sal.lan@localhost:/src/src/sys/arch/i386/compile/obj/SPECIFIC i386

>Description:
That's with cdrdao-1.2.0nb1 from pkgsrc.

Most commands (including teh kinda important 'write' command) were just exiting 
with status 1 after parsing the toc-file.

Looks like function Track::resolveFilename in trackdb/Track.cc in exiting 
without returning a value when it should be returning non-zero. And looks like 
I'm not lucky... :p Adding an explicit 'return true' made it work on my system, 
too.

>How-To-Repeat:
Dunno. Maybe try to run it on full moon.
>Fix:
% diff -u trackdb/Track.cc.orig trackdb/Track.cc
--- trackdb/Track.cc.orig       2005-06-05 22:40:25.000000000 -0400
+++ trackdb/Track.cc    2005-06-05 22:40:25.000000000 -0400
@@ -596,6 +596,7 @@
       }
     }
   }
+  return true;
 }
 
 // Locates 'SubTrack' that contains specified sample.