pkg/30501: automake warns about /usr/pkg/share/aclocal underquoting

[jklowden.schemamania.org%schemamania.org@localhost]

>Number:         30501
>Category:       pkg
>Synopsis:       pkg wxGTK-2.4.2nb4: automake warns about underquoting
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Jun 11 17:00:00 +0000 2005
>Originator:     jklowden.schemamania.org
>Release:        NetBSD 2.0
>Organization:

>Environment:
System: NetBSD oak.schemamania.org 2.0 NetBSD 2.0 (GENERIC) #0: Wed Dec 1 
10:58:25 UTC 2004 
builds@build:/big/builds/ab/netbsd-2-0-RELEASE/i386/200411300000Z-obj/big/builds/ab/netbsd-2-0-RELEASE/src/sys/arch/i386/compile/GENERIC
 i386
Architecture: i386
Machine: i386
autoconf (GNU Autoconf) 2.59
automake (GNU automake) 1.9.5
ltmain.sh (GNU libtool) 1.5.14
local pkgsrc tree updated 22 April 2005.
>Description:
Cf. info automake "5.7 Writing your own aclocal macros" and pkg/30053.  
Automake now complains about underquoted m4 macros.  Any invocation of Automake 
will 
 elicit warning messages for any such macro, whether or not the macro is used
 by that invocation.  

 Fixing the quoting lets us use automake without peering through spurious
 warning messages.  
>How-To-Repeat:
        
>Fix:
The manual says "Starting with Automake 1.8, `aclocal' will warn about all
underquoted calls to `AC_DEFUN'."

The attached patch fixes the macro installed by wxGTK-2.4.2nb4.  


--- /usr/pkg/share/aclocal/orig/wxwin.m4        2005-04-30 17:07:04.000000000 
-0400
+++ /usr/pkg/share/aclocal/wxwin.m4     2005-06-11 11:50:41.000000000 -0400
@@ -33,7 +33,7 @@
 dnl command line options
 dnl ---------------------------------------------------------------------------
 
-AC_DEFUN(AM_OPTIONS_WXCONFIG,
+AC_DEFUN([AM_OPTIONS_WXCONFIG],
 [
    AC_ARG_WITH(wx-prefix, [  --with-wx-prefix=PREFIX   Prefix where wxWindows 
is installed (optional)],
                wx_config_prefix="$withval", wx_config_prefix="")
@@ -56,7 +56,7 @@
 dnl
 dnl Get the cflags and libraries from the wx-config script
 dnl
-AC_DEFUN(AM_PATH_WXCONFIG,
+AC_DEFUN([AM_PATH_WXCONFIG],
 [
   dnl do we have wx-config name: it can be wx-config or wxd-config or ...
   if test x${WX_CONFIG_NAME+set} != xset ; then