pkg/30703: windowmaker 0.92 pkg broken. Doesn't compile properly. Doesn't install

[gcw%primenet.com.au@localhost]

>Number:         30703
>Category:       pkg
>Synopsis:       quick and dirty windowmaker upgrade
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Jul 09 09:18:00 +0000 2005
>Originator:     Geoff C. Wing
>Release:        NetBSD 3.99.7
>Organization:
Geoff Wing : <gcw%pobox.com@localhost>
Rxvt Stuff : <gcw%rxvt.org@localhost>
Zsh Stuff  : <gcw%zsh.org@localhost>
>Environment:
System: NetBSD g.primenet.com.au 3.99.7 NetBSD 3.99.7 (G) #0: Fri Jul 8 
12:20:10 EST 2005 
gcw%g.primenet.com.au@localhost:/usr/netbsd/src/sys/arch/i386/compile/G i386
Architecture: i386
Machine: i386
>Description:
        The change to not use GNUstep directory structure in new WindowMaker
        needs more thought.  And checking.

        The current version does not even install.

        Two options are:
        1) stay without GNUstep and fix the configure file.
           Also patches are needed for all the default menu files which
           use the GNUstep dir heirarchy.

        Around line 26245 in patched configure:

                appspath=$with_gnustepdir

                if test "x$appspath$GNUSTEP_LOCAL_ROOT" = "x"; then
                    wprefs_base_dir=${prefix}
                    wprefs_datadir="${datadir}/WPrefs"
                    wprefs_bindir="${bindir}"

        Because --without-gnustepdir was passed through, the variable
        with_gnustepdir is "no" so this test needs to be fixed.

        2) use the GNUstep dirs.  Apply patch below.
        
>How-To-Repeat:
        try to build/install
>Fix:

--- Makefile.org        2005-07-08 20:44:29.000000000 +1000
+++ Makefile    2005-07-09 18:56:51.000000000 +1000
@@ -20,7 +20,7 @@
 CONFIGURE_ARGS+=       --enable-usermenu
 CONFIGURE_ARGS+=       --sysconfdir=${PKG_SYSCONFBASEDIR}
 CONFIGURE_ARGS+=       --with-nlsdir=${PREFIX}/${PKGLOCALEDIR}/locale
-CONFIGURE_ARGS+=       --without-gnustepdir
+CONFIGURE_ARGS+=       --with-gnustepdir=${PREFIX}/GNUstep
 CONFIGURE_ENV+=                LINGUAS=yes
 CONFIGURE_ENV+=                CPP_PATH="${CPP}"
 
--- PLIST.org   2005-07-08 20:44:29.000000000 +1000
+++ PLIST       2005-07-09 19:07:04.000000000 +1000
@@ -1,5 +1,71 @@
 @comment $NetBSD: PLIST,v 1.11 2005/07/08 09:47:02 adam Exp $
-bin/WPrefs
+GNUstep/Applications/WPrefs.app/WPrefs
+GNUstep/Applications/WPrefs.app/WPrefs.tiff
+GNUstep/Applications/WPrefs.app/WPrefs.xpm
+GNUstep/Applications/WPrefs.app/tiff/advancetonewworkspace.tiff
+GNUstep/Applications/WPrefs.app/tiff/animations.tiff
+GNUstep/Applications/WPrefs.app/tiff/appearance.tiff
+GNUstep/Applications/WPrefs.app/tiff/clip.tiff
+GNUstep/Applications/WPrefs.app/tiff/configs.tiff
+GNUstep/Applications/WPrefs.app/tiff/cycleworkspaces.tiff
+GNUstep/Applications/WPrefs.app/tiff/dock.tiff
+GNUstep/Applications/WPrefs.app/tiff/dontlinkworkspaces.tiff
+GNUstep/Applications/WPrefs.app/tiff/ergonomic.tiff
+GNUstep/Applications/WPrefs.app/tiff/expert.tiff
+GNUstep/Applications/WPrefs.app/tiff/fonts.tiff
+GNUstep/Applications/WPrefs.app/tiff/iconprefs.tiff
+GNUstep/Applications/WPrefs.app/tiff/keyboard.tiff
+GNUstep/Applications/WPrefs.app/tiff/keyboardprefs.tiff
+GNUstep/Applications/WPrefs.app/tiff/keyshortcuts.tiff
+GNUstep/Applications/WPrefs.app/tiff/menualign1.tiff
+GNUstep/Applications/WPrefs.app/tiff/menualign2.tiff
+GNUstep/Applications/WPrefs.app/tiff/menuprefs.tiff
+GNUstep/Applications/WPrefs.app/tiff/menus.tiff
+GNUstep/Applications/WPrefs.app/tiff/moreanim.tiff
+GNUstep/Applications/WPrefs.app/tiff/mousesettings.tiff
+GNUstep/Applications/WPrefs.app/tiff/mousespeed.tiff
+GNUstep/Applications/WPrefs.app/tiff/msty1.tiff
+GNUstep/Applications/WPrefs.app/tiff/msty2.tiff
+GNUstep/Applications/WPrefs.app/tiff/msty3.tiff
+GNUstep/Applications/WPrefs.app/tiff/newstyle.tiff
+GNUstep/Applications/WPrefs.app/tiff/nonopaque.tiff
+GNUstep/Applications/WPrefs.app/tiff/oldstyle.tiff
+GNUstep/Applications/WPrefs.app/tiff/opaque.tiff
+GNUstep/Applications/WPrefs.app/tiff/paths.tiff
+GNUstep/Applications/WPrefs.app/tiff/smooth.tiff
+GNUstep/Applications/WPrefs.app/tiff/sound.tiff
+GNUstep/Applications/WPrefs.app/tiff/speed0.tiff
+GNUstep/Applications/WPrefs.app/tiff/speed0s.tiff
+GNUstep/Applications/WPrefs.app/tiff/speed1.tiff
+GNUstep/Applications/WPrefs.app/tiff/speed1s.tiff
+GNUstep/Applications/WPrefs.app/tiff/speed2.tiff
+GNUstep/Applications/WPrefs.app/tiff/speed2s.tiff
+GNUstep/Applications/WPrefs.app/tiff/speed3.tiff
+GNUstep/Applications/WPrefs.app/tiff/speed3s.tiff
+GNUstep/Applications/WPrefs.app/tiff/speed4.tiff
+GNUstep/Applications/WPrefs.app/tiff/speed4s.tiff
+GNUstep/Applications/WPrefs.app/tiff/tdel.tiff
+GNUstep/Applications/WPrefs.app/tiff/tedit.tiff
+GNUstep/Applications/WPrefs.app/tiff/textr.tiff
+GNUstep/Applications/WPrefs.app/tiff/theme.tiff
+GNUstep/Applications/WPrefs.app/tiff/timer0.tiff
+GNUstep/Applications/WPrefs.app/tiff/timer0s.tiff
+GNUstep/Applications/WPrefs.app/tiff/timer1.tiff
+GNUstep/Applications/WPrefs.app/tiff/timer1s.tiff
+GNUstep/Applications/WPrefs.app/tiff/timer2.tiff
+GNUstep/Applications/WPrefs.app/tiff/timer2s.tiff
+GNUstep/Applications/WPrefs.app/tiff/timer3.tiff
+GNUstep/Applications/WPrefs.app/tiff/timer3s.tiff
+GNUstep/Applications/WPrefs.app/tiff/timer4.tiff
+GNUstep/Applications/WPrefs.app/tiff/timer4s.tiff
+GNUstep/Applications/WPrefs.app/tiff/timer5.tiff
+GNUstep/Applications/WPrefs.app/tiff/timer5s.tiff
+GNUstep/Applications/WPrefs.app/tiff/tnew.tiff
+GNUstep/Applications/WPrefs.app/tiff/whandling.tiff
+GNUstep/Applications/WPrefs.app/tiff/windowfocus.tiff
+GNUstep/Applications/WPrefs.app/tiff/workspace.tiff
+GNUstep/Applications/WPrefs.app/tiff/workspacename.tiff
+GNUstep/Applications/WPrefs.app/tiff/xis.tiff
 bin/convertfonts
 bin/get-wings-flags
 bin/get-wraster-flags
@@ -57,72 +123,6 @@
 share/WINGs/Images.xpm
 share/WINGs/defaultIcon.tiff
 share/WINGs/defaultIcon.xpm
-share/WPrefs/WPrefs.tiff
-share/WPrefs/WPrefs.xpm
-share/WPrefs/tiff/advancetonewworkspace.tiff
-share/WPrefs/tiff/animations.tiff
-share/WPrefs/tiff/appearance.tiff
-share/WPrefs/tiff/clip.tiff
-share/WPrefs/tiff/configs.tiff
-share/WPrefs/tiff/cycleworkspaces.tiff
-share/WPrefs/tiff/dock.tiff
-share/WPrefs/tiff/dontlinkworkspaces.tiff
-share/WPrefs/tiff/ergonomic.tiff
-share/WPrefs/tiff/expert.tiff
-share/WPrefs/tiff/fonts.tiff
-share/WPrefs/tiff/iconprefs.tiff
-share/WPrefs/tiff/keyboard.tiff
-share/WPrefs/tiff/keyboardprefs.tiff
-share/WPrefs/tiff/keyshortcuts.tiff
-share/WPrefs/tiff/menualign1.tiff
-share/WPrefs/tiff/menualign2.tiff
-share/WPrefs/tiff/menuprefs.tiff
-share/WPrefs/tiff/menus.tiff
-share/WPrefs/tiff/moreanim.tiff
-share/WPrefs/tiff/mousesettings.tiff
-share/WPrefs/tiff/mousespeed.tiff
-share/WPrefs/tiff/msty1.tiff
-share/WPrefs/tiff/msty2.tiff
-share/WPrefs/tiff/msty3.tiff
-share/WPrefs/tiff/newstyle.tiff
-share/WPrefs/tiff/nonopaque.tiff
-share/WPrefs/tiff/oldstyle.tiff
-share/WPrefs/tiff/opaque.tiff
-share/WPrefs/tiff/paths.tiff
-share/WPrefs/tiff/smooth.tiff
-share/WPrefs/tiff/sound.tiff
-share/WPrefs/tiff/speed0.tiff
-share/WPrefs/tiff/speed0s.tiff
-share/WPrefs/tiff/speed1.tiff
-share/WPrefs/tiff/speed1s.tiff
-share/WPrefs/tiff/speed2.tiff
-share/WPrefs/tiff/speed2s.tiff
-share/WPrefs/tiff/speed3.tiff
-share/WPrefs/tiff/speed3s.tiff
-share/WPrefs/tiff/speed4.tiff
-share/WPrefs/tiff/speed4s.tiff
-share/WPrefs/tiff/tdel.tiff
-share/WPrefs/tiff/tedit.tiff
-share/WPrefs/tiff/textr.tiff
-share/WPrefs/tiff/theme.tiff
-share/WPrefs/tiff/timer0.tiff
-share/WPrefs/tiff/timer0s.tiff
-share/WPrefs/tiff/timer1.tiff
-share/WPrefs/tiff/timer1s.tiff
-share/WPrefs/tiff/timer2.tiff
-share/WPrefs/tiff/timer2s.tiff
-share/WPrefs/tiff/timer3.tiff
-share/WPrefs/tiff/timer3s.tiff
-share/WPrefs/tiff/timer4.tiff
-share/WPrefs/tiff/timer4s.tiff
-share/WPrefs/tiff/timer5.tiff
-share/WPrefs/tiff/timer5s.tiff
-share/WPrefs/tiff/tnew.tiff
-share/WPrefs/tiff/whandling.tiff
-share/WPrefs/tiff/windowfocus.tiff
-share/WPrefs/tiff/workspace.tiff
-share/WPrefs/tiff/workspacename.tiff
-share/WPrefs/tiff/xis.tiff
 share/WindowMaker/Backgrounds/BlueImage.jpeg
 share/WindowMaker/IconSets/Default.iconset
 share/WindowMaker/Icons/BitchX.tiff
@@ -354,9 +354,9 @@
 @dirrm share/WindowMaker/IconSets
 @dirrm share/WindowMaker/Backgrounds
 @dirrm share/WindowMaker
-@dirrm share/WPrefs/xpm
-@dirrm share/WPrefs/tiff
-@dirrm share/WPrefs
 @dirrm share/WINGs
 @dirrm man/sk/man1
 @dirrm include/WINGs
+@dirrm GNUstep/Applications/WPrefs.app/xpm
+@dirrm GNUstep/Applications/WPrefs.app/tiff
+@dirrm GNUstep/Applications/WPrefs.app