Re: pkg/30362

[Alexander Becher <abecher%kawo2.rwth-aachen.de@localhost>]

rillig%netbsd.org@localhost schrieb:
>Synopsis: do-sandbox-build uses 'which' and wrong quoting
>
>State-Changed-From-To: open->feedback
>State-Changed-By: rillig%netbsd.org@localhost
>State-Changed-When: Mon, 27 Jun 2005 16:04:40 +0000
>State-Changed-Why:
>
>I just committed a fix.

Close, but unfortunately still not working.

Experimenting revealed that neither chroot nor sh accept '--' to signal
the end of all options as I used it in the original report. Something
which is also clearly stated in both manpages, but which I didn't know
before either. So now it should be:

---8<-----8<-----8<---
--- do-sandbox-build    27 Jun 2005 16:04:08 -0000      1.11
+++ do-sandbox-build    13 Jul 2005 18:46:25 -0000
@@ -11,4 +11,4 @@
 build="mk/bulk/build"
 
 chroot /usr/sandbox \
-       $sh -c "cd /usr/pkgsrc && exec $sh $build \"\$@\"" -- $build "$@"
+       $sh -c "cd /usr/pkgsrc && exec $sh $build \"\$@\"" $build "$@"
--->8----->8----->8---

And for do-sandbox-upload as well:

---8<-----8<-----8<---
--- do-sandbox-upload   27 Jun 2005 18:37:22 -0000      1.4
+++ do-sandbox-upload   13 Jul 2005 18:52:37 -0000
@@ -11,4 +11,4 @@
 upload="mk/bulk/upload"
 
 chroot /usr/sandbox \
-       $sh -c "cd /usr/pkgsrc && exec $sh $upload \"\$@\"" -- $upload "$@"
+       $sh -c "cd /usr/pkgsrc && exec $sh $upload \"\$@\"" $upload "$@"
--->8----->8----->8---

This works (for me) as expected.

Regards
Alexander
-- 
PGP key available
Port Payé / Entgelt bezahlt / Postage Paid: http://www.hashcash.org/