Subject: Re: pkg/30920: audio/mpg321 is missing a dependency on audio/libao-oss
To: None <jmmv@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org>
From: Julio M. Merino Vidal <jmmv84@gmail.com>
List: pkgsrc-bugs
Date: 08/19/2005 07:56:02
The following reply was made to PR pkg/30920; it has been noted by GNATS.

From: "Julio M. Merino Vidal" <jmmv84@gmail.com>
To: gnats-bugs@netbsd.org
Cc: gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/30920: audio/mpg321 is missing a dependency on audio/libao-oss
Date: Fri, 19 Aug 2005 09:55:00 +0200

 On 8/19/05, Rui-Xiang Guo <rxg@myrealbox.com> wrote:
 > The following reply was made to PR pkg/30920; it has been noted by GNATS.
 >  Hi,
 >  please try this patch -
 [...]
 >  .if !empty(PKG_OPTIONS:Mlibao-oss)
 >  DEPENDS+=3D              libao-oss>=3D0.8.6:../../audio/libao-oss
 >  .endif
 >=20
 >  .if !empty(PKG_OPTIONS:Mlibao-sun)
 >  DEPENDS+=3D              libao-sun>=3D0.8.6:../../audio/libao-sun
 >  .endif
 
 The whole purpose of the original split of libao was to avoid
 having build-time options, so this is just going backwards.
 
 wiz@'s suggestion (merging libao-sun and libao-oss again into
 libao), is a possible solution to have everything working out
 of the box again, although I don't like it much.  I can live with it
 because it doesn't add extra dependencies on most systems,
 but I like to not install oss stuff if possible.
 
 Though... I just had another idea.  In libao's buildlink file, we'd
 add an extra dependency of the form libao-*:../../audio/libao-oss
 (not sure if the wildcard there could DTRT, but something else
 probably will).  That is, a dependency that accepts any plugin
 and defaults to oss.  This way, whenever you install an app that
 uses libao, libao-oss will be installed iff you hadn't installed any
 other plugin by hand before.  This is binary friendly and avoids
 options.
 
 Do you think this'd be appropriate?
 
 --=20
 Julio M. Merino Vidal <jmmv84@gmail.com>
 http://www.livejournal.com/users/jmmv/
 The NetBSD Project - http://www.NetBSD.org/