pkg/31124: sysutils/rox renames Choices pathname, breaking compatibility

[mkb%incubus.de@localhost]

>Number:         31124
>Category:       pkg
>Synopsis:       sysutils/rox renames Choices pathname, breaking compatibility
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Fri Sep 02 15:50:01 +0000 2005
>Originator:     Matthias Buelow
>Release:        2.0.2, pkgsrc 2005Q2
>Organization:
>Environment:
NetBSD 2.0.2 i386

>Description:
The pkgsrc entry for sysutils/rox installs a shell script
"rox", which redefines the ROX_CHOICES_DIR environment
variable to some arbitrary value ("$HOME/.RoxChoices"),
which breaks compatibility with rox on all other platforms.
Please revert this unnecessary and arbitrary change.
Rox' choices stuff belongs under the default "$HOME/.Choices"
directory, there is no need to set the env variable to
anything.

It is highly annoying to copy over config files from some 
other machine, or maintain them in a synchronized way, only
to find out they don't work on NetBSD, even though it's
the same version of the software, simply because the package   
maintainer has taken the freedom to arbitrarily rename
parts of config pathnames.

Note: this is a BUG, due to the maintainer having bungled
it. It's not a feature that needs to be discussed.

>How-To-Repeat:

>Fix:
The following patch for files/rox corrects the bug
(might get mangled by the web send-pr but you get the idea):

*** rox.old     Fri Sep  2 17:45:25 2005
--- rox Fri Sep  2 17:46:50 2005
***************
*** 3,21 ****
  # $NetBSD: rox,v 1.3 2005/03/23 10:07:34 rxg Exp $
  #
  
- # The user's Choices directory  
- ROX_CHOICES_DIR="$HOME/.RoxChoices"
- 
- #
- # If CHOICESPATH is not set, then check to see whether the user has
- # a $ROX_CHOICES_DIR directory. If they haven't, set one up.
- #
- if [ -z "$CHOICESPATH" ]; then
-       [ ! -d "$ROX_CHOICES_DIR" ] &&                                  \
-                       cp -R @PREFIX@/share/rox/Choices "$ROX_CHOICES_DIR";
-       export CHOICESPATH="$ROX_CHOICES_DIR";
- fi
- 
  # The shared-mime-info directory
  export XDG_DATA_DIRS=@PREFIX@/share
  
--- 3,8 ----