Re: pkg/31916: Better checks in bsd.pkg.mk if pkg_create happens to core dump during install

[Lubomir Sedlacik <salo%Xtrmntr.org@localhost>]

The following reply was made to PR pkg/31916; it has been noted by GNATS.

From: Lubomir Sedlacik <salo%Xtrmntr.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/31916: Better checks in bsd.pkg.mk if pkg_create happens to 
core dump during install
Date: Wed, 26 Oct 2005 09:30:38 +0200

 --RVlUGXxwBj5SDcM9
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 On Tue, Oct 25, 2005 at 11:34:00PM +0000, 
lars.nordlund%hem.utfors.se@localhost wrote:
 > >Synopsis:       Better checks in bsd.pkg.mk if pkg_create happens to
 > >core dump during install
 >=20
 > i.e. 'make install' silently fails leaving the package with an empty
 > +CONTENTS file. This causes problems for other packages because they=20
 > can't be properly buildlinked (or something like that?).
 >=20
 > After some discussions I came up with this patch:
 
 i don't like it, it hides the real problem.  pkg_create should not dump
 core in the first place.
 
 > The diff:
 > ...
 > This catches non-zero exit values from pkg_create and tries to give
 > some kind of information about what to do.
 
 better solution would be to fix pkg_create not to crash when the pkg
 database is corrupted and return sane exit values.  _then_ you can give
 meaningful messages back to the user.  this is a very dirty hack..
 
 
 regards,
 
 --=20
 -- Lubomir Sedlacik <salo@{NetBSD,Xtrmntr,silcnet}.org>   --
 
 --RVlUGXxwBj5SDcM9
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.6 (NetBSD)
 
 iD8DBQFDXzCeiwjDDlS8cmMRApRqAJ42oTzJNyiC2I1PwPhLwuX4WjRqWACfY9j1
 XpSLfEQG9mFTt6cq5TKDViY=
 =pNx2
 -----END PGP SIGNATURE-----
 
 --RVlUGXxwBj5SDcM9--