pkg/31948: irssi perl support broken when using binary package

[carton%Ivy.NET@localhost]

>Number:         31948
>Category:       pkg
>Synopsis:       irssi perl support broken when using binary package
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Oct 30 05:26:00 +0000 2005
>Originator:     Miles Nordin
>Release:        NetBSD 3.0_BETA
>Organization:
Ivy Ministrires
>Environment:
System: NetBSD castrovalva 3.0_BETA NetBSD 3.0_BETA (CASTROVALVA-$Revision: 
1.10 $) #1: Tue Sep 20 18:06:04 EDT 2005 
carton@castrovalva:/export/src/sys/arch/alpha/compile/CASTROVALVA alpha
Architecture: alpha
Machine: alpha
>Description:
If irssi is installed from binary package with PKG_OPTIONS.irssi=perl, 
Perl won't work.  the PLIST is wrong.

AFAICT the problem is, you cannot use PERL5_PACKLIST unless you 
.include ../../lang/perl5/module.mk, and irssi does not do that.  so 
the irssi package is setting PERL5_PACKLIST, but nobody is listening.

since the PLIST is wrong, Perl will work in irssi if you 'make install' 
but won't work if you install a binary package.

>How-To-Repeat:
1. build irssi using 'make package'
2. rm -rf /usr/pkg
3. pkg_add irssi

or, just look at pkg_info -L irssi and see that the perl stuff is 
missing from the PLIST.
>Fix:
This fixes it for me.

Index: PLIST
===================================================================
RCS file: /scratch/cvsroot/netbsd/pkgsrc/chat/irssi/PLIST,v
retrieving revision 1.1.1.5
diff -u -r1.1.1.5 PLIST
--- PLIST       2 Apr 2005 21:35:53 -0000       1.1.1.5
+++ PLIST       30 Oct 2005 05:17:53 -0000
@@ -1,6 +1,22 @@
 @comment $NetBSD: PLIST,v 1.7 2005/03/19 15:32:25 jmmv Exp $
 bin/irssi
 lib/irssi/modules/libirc_proxy.la
+${PERL5_COMMENT}${PERL5_SUB_INSTALLVENDORARCH}/auto/Irssi/.packlist
+${PERL5_COMMENT}${PERL5_SUB_INSTALLVENDORARCH}/auto/Irssi/Irc/.packlist
+${PERL5_COMMENT}${PERL5_SUB_INSTALLVENDORARCH}/auto/Irssi/Irc/Irc.bs
+${PERL5_COMMENT}${PERL5_SUB_INSTALLVENDORARCH}/auto/Irssi/Irc/Irc.so
+${PERL5_COMMENT}${PERL5_SUB_INSTALLVENDORARCH}/auto/Irssi/Irssi.bs
+${PERL5_COMMENT}${PERL5_SUB_INSTALLVENDORARCH}/auto/Irssi/Irssi.so
+${PERL5_COMMENT}${PERL5_SUB_INSTALLVENDORARCH}/auto/Irssi/TextUI/.packlist
+${PERL5_COMMENT}${PERL5_SUB_INSTALLVENDORARCH}/auto/Irssi/TextUI/TextUI.bs
+${PERL5_COMMENT}${PERL5_SUB_INSTALLVENDORARCH}/auto/Irssi/TextUI/TextUI.so
+${PERL5_COMMENT}${PERL5_SUB_INSTALLVENDORARCH}/auto/Irssi/UI/.packlist
+${PERL5_COMMENT}${PERL5_SUB_INSTALLVENDORARCH}/auto/Irssi/UI/UI.bs
+${PERL5_COMMENT}${PERL5_SUB_INSTALLVENDORARCH}/auto/Irssi/UI/UI.so
+${PERL5_COMMENT}${PERL5_SUB_INSTALLVENDORARCH}/Irssi/Irc.pm
+${PERL5_COMMENT}${PERL5_SUB_INSTALLVENDORARCH}/Irssi/UI.pm
+${PERL5_COMMENT}${PERL5_SUB_INSTALLVENDORARCH}/Irssi/TextUI.pm
+${PERL5_COMMENT}${PERL5_SUB_INSTALLVENDORARCH}/Irssi.pm
 man/man1/irssi.1
 share/doc/irssi/botnet.txt
 share/doc/irssi/design.txt
@@ -151,6 +167,11 @@
 share/irssi/scripts/usercount.pl
 share/irssi/themes/colorless.theme
 share/irssi/themes/default.theme
+${PERL5_COMMENT}@dirrm ${PERL5_SUB_INSTALLVENDORARCH}/auto/Irssi/UI
+${PERL5_COMMENT}@dirrm ${PERL5_SUB_INSTALLVENDORARCH}/auto/Irssi/TextUI
+${PERL5_COMMENT}@dirrm ${PERL5_SUB_INSTALLVENDORARCH}/auto/Irssi/Irc
+${PERL5_COMMENT}@dirrm ${PERL5_SUB_INSTALLVENDORARCH}/auto/Irssi
+${PERL5_COMMENT}@dirrm ${PERL5_SUB_INSTALLVENDORARCH}/Irssi
 @dirrm share/irssi/themes
 @dirrm share/irssi/scripts
 @dirrm share/irssi/help
Index: options.mk
===================================================================
RCS file: /scratch/cvsroot/netbsd/pkgsrc/chat/irssi/options.mk,v
retrieving revision 1.1.1.2
diff -u -r1.1.1.2 options.mk
--- options.mk  29 Aug 2005 20:02:42 -0000      1.1.1.2
+++ options.mk  30 Oct 2005 05:18:17 -0000
@@ -7,16 +7,16 @@
 .include "../../mk/bsd.options.mk"
 
 .if !empty(PKG_OPTIONS:Mirssi-perl)
-PERL5_PACKLIST=                auto/Irssi/.packlist
-PERL5_PACKLIST+=       auto/Irssi/Irc/.packlist
-PERL5_PACKLIST+=       auto/Irssi/UI/.packlist
-PERL5_PACKLIST+=       auto/Irssi/TextUI/.packlist
+.include "../../lang/perl5/vars.mk"
+PLIST_SUBST+=          PERL5_COMMENT=
+PLIST_SUBST+=          
PERL5_SUB_INSTALLVENDORARCH=${PERL5_SUB_INSTALLVENDORARCH:Q}
 .include "../../lang/perl5/buildlink3.mk"
 # actually we don't need --with-perl here, irssi is compiled with it by default
 # but who knows what may happen in future versions
 CONFIGURE_ARGS+=       --with-perl
 CONFIGURE_ARGS+=       --with-perl-lib=vendor
 .else
+PLIST_SUBST+=          PERL5_COMMENT="@comment "
 CONFIGURE_ARGS+=       --with-perl=no
 .endif
 

>Unformatted:
 pkgsrc 2005-08-24