pkg/32239: version of pkg_install not checked for all targets

[Klaus Heinz <k.heinz.dez.fuenf%onlinehome.de@localhost>]

>Number:         32239
>Category:       pkg
>Synopsis:       version of pkg_install not checked for all targets
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Dec 04 15:45:00 +0000 2005
>Originator:     Klaus Heinz
>Release:        NetBSD 1.6.2
>Organization:
none
>Description:
        The version of the available pkg_* tools is not checked early enough
        for all targets. This results in a confusing error message during
        "make clean".
        The "clean" target does not check whether PKG_FAIL_REASON is defined
        like all other top-level targets (fetch checksum extract patch
        configure all build install package update) do and thus make does not
        abort if PKG_FAIL_REASON is defined as a result of out-of-date pkg_*
        tools.
        
>How-To-Repeat:

        pkgsrc from 2005-12-04

        $ pkg_info -V
        20050718
        $ cd /usr/pkgsrc/x11/gtk2
        $ make clean
        Syntax error: "&&" unexpected
        cd: can't cd to ../../Error:
        cd: can't cd to ../../The
        cd: can't cd to ../../package
        cd: can't cd to ../../tools
        cd: can't cd to ../../installed
        cd: can't cd to ../../on
        cd: can't cd to ../../this
        cd: can't cd to ../../system
        cd: can't cd to ../../are
        cd: can't cd to ../../out
        cd: can't cd to ../../of
        cd: can't cd to ../../date.
        cd: can't cd to /usr/pkgsrc/x11/gtk2/../../date.
        cd: can't cd to /usr/pkgsrc/x11/gtk2/../../of
        cd: can't cd to /usr/pkgsrc/x11/gtk2/../../out
        cd: can't cd to /usr/pkgsrc/x11/gtk2/../../are
        cd: can't cd to /usr/pkgsrc/x11/gtk2/../../system
        cd: can't cd to /usr/pkgsrc/x11/gtk2/../../this
        cd: can't cd to /usr/pkgsrc/x11/gtk2/../../on
        cd: can't cd to /usr/pkgsrc/x11/gtk2/../../installed
        cd: can't cd to /usr/pkgsrc/x11/gtk2/../../tools
        cd: can't cd to /usr/pkgsrc/x11/gtk2/../../package
        cd: can't cd to /usr/pkgsrc/x11/gtk2/../../The
        cd: can't cd to /usr/pkgsrc/x11/gtk2/../../Error:
        cd: can't cd to /usr/pkgsrc/x11/gtk2/../../===>
        *** Error code 2

        Stop.
        make: stopped in /usr/pkgsrc/x11/gtk2
        *** Error code 1

        Stop.
        make: stopped in /usr/pkgsrc/x11/gtk2

        $ make PKG_DEBUG_LEVEL=2 show-all-depends-dirs-excl 
        Syntax error: "&&" unexpected
        cd: can't cd to ../../Error:
        cd: can't cd to ../../The
        cd: can't cd to ../../package
        cd: can't cd to ../../tools
        cd: can't cd to ../../installed
        cd: can't cd to ../../on
        cd: can't cd to ../../this
        cd: can't cd to ../../system
        cd: can't cd to ../../are
        cd: can't cd to ../../out
        cd: can't cd to ../../of
        cd: can't cd to ../../date.
        date. of out are system this on installed tools package The Error: ===>

>Fix:
        Include "clean" in the list of targets where PKG_FAIL_REASON is
        checked or avoid recursive MAKE calls which may depend on the version
        of the pkg_* tools.