Re: pkg/32275: The program l2tpd from the net/rp-l2tp package does not run on NetBSD-2.0/i386

["Fr. Chuck Zmudzinski, C.P.M." <brchuck%hotmail.com@localhost>]

The following reply was made to PR pkg/32275; it has been noted by GNATS.

From: "Fr. Chuck Zmudzinski, C.P.M." <brchuck%hotmail.com@localhost>
To: <gnats-bugs%netbsd.org@localhost>
Cc: 
Subject: Re: pkg/32275: The program l2tpd from the net/rp-l2tp package does not 
run on NetBSD-2.0/i386
Date: Sun, 11 Dec 2005 12:59:17 -0500

 ----- Original Message ----- 
 From: "Lubomir Sedlacik" <salo%Xtrmntr.org@localhost>
 To: <pkg-manager%netbsd.org@localhost>; <gnats-admin%netbsd.org@localhost>;
 <pkgsrc-bugs%netbsd.org@localhost>; <brchuck%hotmail.com@localhost>
 Sent: Saturday, December 10, 2005 6:30 PM
 Subject: Re: pkg/32275: The program l2tpd from the net/rp-l2tp package does
 not run on NetBSD-2.0/i386
 
 
 > The following reply was made to PR pkg/32275; it has been noted by GNATS.
 >
 > From: Lubomir Sedlacik <salo%Xtrmntr.org@localhost>
 > To: gnats-bugs%netbsd.org@localhost
 > Cc:
 > Subject: Re: pkg/32275: The program l2tpd from the net/rp-l2tp package
 does not run on NetBSD-2.0/i386
 > Date: Sun, 11 Dec 2005 00:28:11 +0100
 >
 >  --hUen2UJD5eWDKlb+
 >  Content-Type: text/plain; charset=us-ascii
 >  Content-Disposition: inline
 >  Content-Transfer-Encoding: quoted-printable
 >
 >  On Sat, Dec 10, 2005 at 11:25:00PM +0000, brchuck%hotmail.com@localhost 
 > wrote:
 >  > >Fix:
 >  > I fixed it by adding the -Wl,-E option to the rule for building l2tpd
 >  > in the Makefile that was generated by pkgsrc in the process of
 >  > building the package. After that, it still did not work (I got another
 >  > undefined PLT symbol error) until I added the -lutil option to the
 >  > rule for building the sync-pppd.so handler in the Makefile of the
 >  > handlers directory. These changes can be integrated into pkgsrc by
 >  > replacing patch-ab with the patch-ab listed below, and by adding
 >  > patch-ah as listed below to the patches directory:
 >  >=20
 >  > Replace patch-ab with this to add the -Wl,-E option for building l2tpd
 >  > on NetBSD:
 >  >=20
 >  > --- Makefile.in.orig 2002-09-30 16:33:55.000000000 -0400
 >  > +++ Makefile.in 2005-12-10 09:16:01.000000000 -0500
 >  > @@ -26,11 +26,21 @@
 >  >  install_dir=3D@INSTALL@ -d
 >  >  sbindir=3D@sbindir@
 >  > =20
 >  > +OPSYS=3D $(shell uname -s)
 >  > +
 >  >  OBJS=3Dauth.o debug.o dgram.o main.o md5.o network.o options.o peer.o
 se=
 >  ssion.o tunnel.o utils.o
 >  > -EXTRA_LIBS=3D@LIBEVENT@/*.o -ldl
 >  > +
 >  > +ifeq (${OPSYS}, Linux)
 >  > +EXTRA_LIBS=3D-ldl
 >  > +DYNAMIC_FLAGS=3D -rdynamic
 >  > +endif
 >  > +
 >  > +ifeq (${OPSYS}, NetBSD)
 >  > +DYNAMIC_FLAGS=3D -Wl,-E
 >  > +endif
 >  > =20
 >  > @@ -43,7 +53,7 @@
 >  > =20
 >  >  l2tpd: libl2tp.a libevent/libevent.a
 >  >  $(MAKE) -C handlers
 >  > - @CC@ -o l2tpd -rdynamic $(OBJS) $(EXTRA_LIBS)
 >  > + @CC@ -o l2tpd $(DYNAMIC_FLAGS) $(OBJS) @LIBEVENT@/*.o $(EXTRA_LIBS)
 >
 >  this is unnecessary, just use the EXPORT_SYMBOLS_LDFLAGS variable
 >  defined by the pkgsrc infrastructure to DTRT.
 >
 >  regards,
 
 I don't know the best way in pkgsrc to implememt this fix, that is what I
 hope you will do. The main point I wanted to make is that the apparent cause
 of the Undefined PLT symbol error in this package, as reported elsewhere on
 other platforms (see for example
 http://mail-index.netbsd.org/port-macppc/2004/05/23/0004.html), is the fact
 that the export-dynamic symbols flag is not being invoked when linking
 l2tpd, and that sync-pppd.so is not being linked against libutil. The
 patches I submitted are against the original Makefile.in files - patch-ab
 patches Makefile.in.orig, and patch-ah patches handlers/Makefile.in. If you
 want my patch between the current patch-ab and my suggested patch-ab, it is
 simply this - only one line to add to invoke the correct flag when OPSYS is
 NetBSD:
 
 --- patch-ab 2003-12-18 11:39:18.000000000 -0500
 +++ patch-ab 2005-12-11 12:51:22.000000000 -0500
 @@ -17,6 +17,7 @@
  +endif
  +
  +ifeq (${OPSYS}, NetBSD)
 ++DYNAMIC_FLAGS= -Wl,-E
  +endif
 
   SRCS=$(OBJS:.o=.c)
 -------------------------------------------
 regards,
 
 Charles Zmudzinski
 >
 >  --=20
 >  -- Lubomir Sedlacik <salo@{NetBSD,Xtrmntr,silcnet}.org>   --
 >
 >  --hUen2UJD5eWDKlb+
 >  Content-Type: application/pgp-signature
 >  Content-Disposition: inline
 >
 >  -----BEGIN PGP SIGNATURE-----
 >  Version: GnuPG v1.4.2 (NetBSD)
 >
 >  iD8DBQFDm2SLiwjDDlS8cmMRAjNPAJ0cM1Pw/GXZcTiL3sxNSRgg7FeUnACggLPN
 >  60ayTSXjZDUCKzjLJAk8tQc=
 >  =qK1t
 >  -----END PGP SIGNATURE-----
 >
 >  --hUen2UJD5eWDKlb+--
 >
 >
 >