pkgsrc-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: pkg/32415: download-vulnerability-list not exiting when no PKGVULNDIR



The following reply was made to PR pkg/32415; it has been noted by GNATS.

From: "Jeremy C. Reed" <reed%reedmedia.net@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/32415: download-vulnerability-list not exiting when no
 PKGVULNDIR
Date: Thu, 29 Dec 2005 16:52:44 -0800 (PST)

 On Fri, 30 Dec 2005 reed%reedmedia.net@localhost wrote:
 
 > if [ ! -d ${PKGVULNDIR}/. ]; then
 > +    @MKDIR@ ${PKGVULNDIR} || { echo "Can't create ${PKGVULNDIR}" 1>&2; exit 
 > 1; }
 >      echo "Creating ${PKGVULNDIR}"
 > -    @MKDIR@ ${PKGVULNDIR} || (echo "Can't create ${PKGVULNDIR}" 1>&2; exit 
 > 1)
 > fi
 
 I forgot: probably error message is redundant as mkdir will also have its 
 error message too.
 
 And I placed the echo after because I didn't want it to say "Creating" if 
 it never happened (especially in the broken case). This probably doesn't 
 matter once this is fixed.
 
 
   Jeremy C. Reed
 
                         BSD News, BSD tutorials, BSD links
                         http://www.bsdnewsletter.com/
 



Home | Main Index | Thread Index | Old Index