pkg/32824: undefined variable in audio/mpg123 breaks "bmake index" on linux

[bdragon%mailsnare.net@localhost]

>Number:         32824
>Category:       pkg
>Synopsis:       undefined variable in audio/mpg123 breaks "bmake index" on 
>linux
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Feb 13 19:55:02 +0000 2006
>Originator:     Brandon Bergren
>Release:        n/a
>Organization:
>Environment:
>Description:
Running "bmake index" in the pkgsrc root on linux breaks due to an undefined 
variable in audio/mpg123.

When the platform is "linux", audio/mpg123/Makefile.common does
.  if ${TARGET_SUFFIX} == "-nas"

without testing if TARGET_SUFFIX is defined.

Attached is a patch that tests whether TARGET_SUFFIX is defined before doing a 
comparison.
>How-To-Repeat:
Run "bmake index" on a linux+pkgsrc system.
>Fix:
===================================================================
RCS file: /cvsroot/pkgsrc/audio/mpg123/Makefile.common,v
retrieving revision 1.27
diff -u -r1.27 Makefile.common
--- Makefile.common     9 Jan 2006 22:04:38 -0000       1.27
+++ Makefile.common     13 Feb 2006 19:33:49 -0000
@@ -45,7 +45,7 @@
 .elif ${OPSYS} == "IRIX"
 BUILD_TARGET=  sgi
 .elif ${OPSYS} == "Linux"
-.  if ${TARGET_SUFFIX} == "-nas"
+.  if defined(TARGET_SUFFIX) && ${TARGET_SUFFIX} == "-nas"
 BUILD_TARGET=  linux-nas
 .  elif ${MACHINE_ARCH} == "i386"
 BUILD_TARGET=  linux