pkg/32990: misc/visual-regexp needs better install method

[kre%munnari.OZ.AU@localhost]

>Number:         32990
>Category:       pkg
>Synopsis:       misc/visual-regexp needs better install method
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Mar 04 14:55:01 +0000 2006
>Originator:     Robert Elz
>Release:        NetBSD 3.99.15  (pkgsrc current as of a few hours ago)
>Organization:
        Prince of Songkla University
>Environment:
System: NetBSD jade.coe.psu.ac.th 3.99.15 NetBSD 3.99.15 
(GENERIC-1.696-20060125) #8: Wed Jan 25 04:59:39 ICT 2006 
kre%jade.coe.psu.ac.th@localhost:/usr/obj/current/kernels/JADE_ASUS i386
        packages compiled using pkg_comp with libkver and 3.0 release sets
Architecture: i386
Machine: i386
>Description:
        misc/visual-regexp installs with any version of tk >= 8.3.2
        (which obviously includes 8.4.12nb2 (the current x11/tk)
        which is what I have installed.   However, when installed, the
        visual_regexp script wants wish8.3 which only gets installed
        with x11/tk83.   There doesn't seem to be any good reason for
        that, from what I can tell (very minimal testing) it works
        fine with tk 8.4.12

        Also (very minor bug, but which perhaps can get fixed at the
        same time), the Usage string in the help window (once you
        have visual_regexp working) says
                Usage: tkregexp <sampleFile>
        where it probably should say
                Usage: visual_regexp <samplefile?

        I don't know who/where/when the name was changed from tkregexp
        to visual_regexp (ie: whether this is a pkgsrc name change, or
        something done by its author) so I don't know if this one is
        one that should be sent back to the author to fix or not (if it
        should, then it isn't important enough to bother with a pkgsrc
        patch to handle in the interim)

>How-To-Repeat:
        Install (or update to) current versions of tk (and anything else
        that requires), and then install misc/visual-regesp

jade$ pkg_info | grep ^tk
tk-8.4.12nb2        Graphical toolkit for TCL
jade$ pkg_info | grep ^visual
visual_regexp-3.0nb1 Easily design and debug regular expressions graphically

        Then look at the start of /usr/pkg/bin/visual_regexp (obviously
        using whatever LOCALBASE you're using)...

jade$ sed 8q /usr/pkg/bin/visual_regexp
#!/bin/sh  
#-*-tcl-*-  
# the next line restarts using wish \
exec wish8.3 "$0" -- ${1+"$@"}


set version 3.0

        Note the "exec wish8.3" which is expecting a version of Tk
        which I don't have installed (and which pkgsrc did not
        install for me).

        If you make it work (by changing the 8.3 to 8.4 - or, I
        assume, by installing x11/tk83, then click on the help
        button in the upper right corner of the main window to see
        the help page with the erroneous usage string.

>Fix:
        Do some of the install script munging that pkgsrc is good
        at to convert the "wish8.3" string into whichever version of
        wish is actually installed.   Either that, or simply change it
        to use "wish" instead of being pedantic about which version
        it wants.   Alternatively, I suppose it would be possible to
        have it demand that tk83 be installed, rather than any tk
        after (or exatlY) 8.3.2 - but there doesn't seem to be a need
        for that, given that it seems to work OK using 8.4.12.