Re: pkg/33027: x11/xfce4-utils - xinitrc cleanup (Solaris issues)

[segv%netctl.net@localhost]

The following reply was made to PR pkg/33027; it has been noted by GNATS.

From: segv%netctl.net@localhost
To: gnats-bugs%netbsd.org@localhost
Cc: reed%reedmedia.net@localhost, pkg-manager%netbsd.org@localhost,
        gnats-admin%netbsd.org@localhost, pkgsrc-bugs%netbsd.org@localhost
Subject: Re: pkg/33027: x11/xfce4-utils - xinitrc cleanup (Solaris issues)
Date: Wed, 8 Mar 2006 01:00:42 +0000

 On Wed,  8 Mar 2006 00:35:02 +0000 (UTC)
 "Jeremy C. Reed" <reed%reedmedia.net@localhost> wrote:
 
 > The following reply was made to PR pkg/33027; it has been noted by GNATS.
 > 
 > From: "Jeremy C. Reed" <reed%reedmedia.net@localhost>
 > To: gnats-bugs%netbsd.org@localhost
 > Cc: 
 > Subject: Re: pkg/33027: x11/xfce4-utils - xinitrc cleanup (Solaris issues)
 > Date: Tue, 7 Mar 2006 15:59:42 -0800 (PST)
 > 
 >  On Tue, 7 Mar 2006 segv%netctl.net@localhost wrote:
 >  
 >  >  if test "x$UID" = "x"; then
 >  > -       UID=`id -u`
 >  
 >  Maybe this part could have something like @@ID@@ which is replaced with 
 >  bmake's ${ID} or ${TOOLS_PLATFORM.id}
 >  
 I'm not sure what those variables do, that you mention, all I know is that 
 
 UID=`id -u`
 
 is supposed to extract user's numeric id for creating a unique temporary file 
under /tmp. The problem is Solaris has two 'id' commands: /bin/id does not 
support '-u' arg, /usr/xpg4/bin/id does.
 
 >  > -if test -z "$SSH_AGENT_PID" -a "$sshagent" -a "x$sshagent" != "xno"; then
 >  > +if test x"$SSH_AGENT_PID" = "x" -a -f "$sshagent"; then
 >  
 >  What about the $sshagent not equaling "no"?
 >  
 What about it? As far as I can see the logic is as follows:
 
 sshagent=`which ssh-agent`
 
 if $SSH_AGENT_PID is not set (i.e. ssh-agent is not running) and $sshagent 
points to ssh-agent executable, then run ssh-agent. The original code is quite 
twisted and difficult to understand, I replaced it with something simpler.
 
 >  You may want to share these and your other suggestions directly to the 
 >  upstream developers via http://www.xfce.org/ also.
 >  
 Yeah, I was thinking about that.