PR/30267 CVS commit: pkgsrc/multimedia/libdv

["Jeremy C. Reed" <reed%netbsd.org@localhost>]

The following reply was made to PR pkg/30267; it has been noted by GNATS.

From: "Jeremy C. Reed" <reed%netbsd.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: PR/30267 CVS commit: pkgsrc/multimedia/libdv
Date: Sat, 11 Mar 2006 04:08:47 +0000 (UTC)

 Module Name:   pkgsrc
 Committed By:  reed
 Date:          Sat Mar 11 04:08:47 UTC 2006
 
 Modified Files:
        pkgsrc/multimedia/libdv: Makefile.common
 
 Log Message:
 This is to fix PR 30267. (I have noticed same problem.)
 
 The build needs optimization. So if CFLAGS doesn't contain at least
 -O then add it. (Thank you Juan for idea.)
 
 On the tech-pkg-ja%jp.NetBSD.org@localhost list, I was told (19 Dec 2005):
 
 > This change can be accepted when judged only from my environment (i386),
 > since the expression of "if empty(CFLAGS:M-O*)" is evaluated
 > after setting of the environment variable (-O2).
 > However, I do not have the positive proof whether this expression is 
 > evaluated
 > after setting of the environment variable (-O2), in all environments.
 
 So hopefully this doesn't break for anyone else.
 
 
 To generate a diff of this commit:
 cvs rdiff -r1.4 -r1.5 pkgsrc/multimedia/libdv/Makefile.common
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.