pkg/33428: broken package wm/icecc fix

[plunky%rya-online.net@localhost]

>Number:         33428
>Category:       pkg
>Synopsis:       wm/icecc is showing as broken in the bulk builds, fix attached
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat May 06 10:55:00 +0000 2006
>Originator:     Iain Hibbert
>Release:        NetBSD 3.99.17
>Organization:
http://maps.google.com/maps?q=ireland&ll=52.2711,-9.8630&spn=0.0244,0.0822&t=k
>Environment:
        
        
System: NetBSD galant 3.99.17 NetBSD 3.99.17 (GALANT) #27: Fri May 5 22:07:02 
BST 2006 plunky@galant:/home/obj/sys/arch/i386/compile/GALANT i386
Architecture: i386
Machine: i386
>Description:
        The bulk build is failing with the following errors.

/usr/pkg/bin/icecolsel:          -lpthread.20 => not found
/usr/pkg/bin/icefonsel:          -lpthread.20 => not found
*** The above programs/libs will not find the listed shared libraries
    at runtime. Please fix the package (add -Wl,-R.../lib in the right places)!
*** Error code 1

Stop.
        
>How-To-Repeat:
        

        bulk build pkgsrc I guess :)
>Fix:
        

        My fix is to change the Makefile so that the pkgsrc LDFLAGS etc are 
used,
        which will include the relevant flags. distinfo also changes

Index: patches/patch-aa
===================================================================
RCS file: /cvsroot/pkgsrc/wm/icecc/patches/patch-aa,v
retrieving revision 1.2
diff -u -r1.2 patch-aa
--- patches/patch-aa    8 Apr 2006 16:30:57 -0000       1.2
+++ patches/patch-aa    6 May 2006 10:43:52 -0000
@@ -13,8 +13,8 @@
  
  icefonsel: icefonsel.cpp
 -      g++ $(INCLUDE_QT) $(LIB_QT) -lqt icefonsel.cpp -o icefonsel
-+      g++ $(INCLUDE_QT) $(LIB_QT) -lqt-mt icefonsel.cpp -o icefonsel
++      $(CC) $(CFLAGS) $(CPPFLAGS) $(LDFLAGS) $(INCLUDE_QT) $(LIB_QT) -lqt-mt 
icefonsel.cpp -o icefonsel
  
  icecolsel: icecolsel.cpp
 -      g++ $(INCLUDE_QT) $(LIB_QT) -lqt icecolsel.cpp -o icecolsel
-+      g++ $(INCLUDE_QT) $(LIB_QT) -lqt-mt icecolsel.cpp -o icecolsel
++      $(CC) $(CFLAGS) $(CPPFLAGS) $(LDFLAGS) $(INCLUDE_QT) $(LIB_QT) -lqt-mt 
icecolsel.cpp -o icecolsel

Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/wm/icecc/distinfo,v
retrieving revision 1.2
diff -u -r1.2 distinfo
--- distinfo    8 Apr 2006 16:30:57 -0000       1.2
+++ distinfo    6 May 2006 10:43:52 -0000
@@ -36,6 +36,6 @@
 SHA1 (icewoed-1.8.tar.bz2) = ca58b5769c27ee587458c12c285e231b990c3da9
 RMD160 (icewoed-1.8.tar.bz2) = 51cf2873f005e8c74239b138d6e5b9f8a1505047
 Size (icewoed-1.8.tar.bz2) = 21955 bytes
-SHA1 (patch-aa) = 145aa9580bb9984513382b6f5c643974ea6744fe
+SHA1 (patch-aa) = 76ca73f4710b267d2504d27ca806ec717ffb86aa
 SHA1 (patch-ab) = e4cefad52c55b548e1e59dd40799d5cbee9477fe
 SHA1 (patch-ac) = d695ab2fe41c6eba3e827a0f7db59fbf4b376805

>Unformatted: