Subject: Re: pkg/33428: broken package wm/icecc fix
To: None <pkg-manager@netbsd.org, gnats-admin@netbsd.org,>
From: Iain Hibbert <plunky@rya-online.net>
List: pkgsrc-bugs
Date: 05/08/2006 20:30:06
The following reply was made to PR pkg/33428; it has been noted by GNATS.
From: Iain Hibbert <plunky@rya-online.net>
To: gnats-bugs@netbsd.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org,
pkgsrc-bugs@netbsd.org
Subject: Re: pkg/33428: broken package wm/icecc fix
Date: Mon, 8 May 2006 21:23:21 +0100 (BST)
On Mon, 8 May 2006, joerg@britannica.bec.de wrote:
> OK, so we talk about the same problem. While I don't think that the
> patch is wrong, it should not be needed since PTHREAD_LIBS +
> PTHREAD_LDFLAGS should be self-contained in my understanding. If it is
> missing the rpath entry e.g. in case of pth, this looks wrong.
My thought was that it only happens because the gmakefile is hardwired,
and the pthread.buildlink3.mk/builtin.mk would just assume that if
pthreads are built in then nothing needs to be added because LDFLAGS
should be enough.
In fact, the patch would technically be slightly wrong I just realised, it
should be using
$(CXX) $(CXXFLAGS) ..
instead of
$(CC) $(CFLAGS) ..
?
iain