Re: pkg/33494: net/vsftpd doesn't build on Solaris

[Stefan Pfetzing <dreamind%dreamind.de@localhost>]

The following reply was made to PR pkg/33494; it has been noted by GNATS.

From: Stefan Pfetzing <dreamind%dreamind.de@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/33494: net/vsftpd doesn't build on Solaris
Date: Tue, 16 May 2006 17:09:32 +0200

 Hi Joerg,
 
 Am 16.05.2006 um 16:55 schrieb joerg%britannica.bec.de@localhost:
 
 >  On Tue, May 16, 2006 at 02:30:01PM +0000, dreamind%dreamind.de@localhost 
 > wrote:
 >> diff -uraN ../net/vsftpd/Makefile vsftpd/Makefile
 >> --- ../net/vsftpd/Makefile      2006-04-23 20:11:49.809006262 +0200
 >> +++ vsftpd/Makefile     2006-05-16 16:05:59.206507877 +0200
 >> @@ -1,8 +1,10 @@
 >>  # $NetBSD: Makefile,v 1.22 2006/04/23 00:12:41 jlam Exp $
 >>  #
 >> +#
 >> +.include "../../mk/bsd.prefs.mk"
 >
 >  This should go down after the initial variable chunk at the very  
 > least.
 
 Ok.
 
 >>
 >>  DISTNAME=      vsftpd-2.0.4
 >> -PKGREVISION=   1
 >> +PKGREVISION=   2
 >
 >  This is not necessary, since the package didn't work before?
 
 Well right, even though IMHO everytime the revision should be  
 increased, but I guess this will trigger unneeded rebuilds on other  
 systems.
 
 >>  CATEGORIES=    net
 >>  MASTER_SITES=  ftp://vsftpd.beasts.org/users/cevans/
 >>
 >> @@ -35,6 +37,9 @@
 >>  SUBST_FILES.paths=     vsftpd.8 vsftpd.conf.5 vsftpd.conf
 >>  SUBST_SED.paths+=      -e 's,@PKG_SYSCONFDIR@,${PKG_SYSCONFDIR},g'
 >>  SUBST_STAGE.paths=     post-patch
 >> +.if (${OPSYS} == "SunOS")
 >> +BUILD_MAKE_FLAGS+=     LDFLAGS="-L/usr/pkg/lib -Wl,-R/usr/pkg/ 
 >> lib:/usr/lib -lcrypto -lwrap -lrt -lssl -lpam"
 >
 >  This is certainly not the correct solution. Can you explain  
 > exactly how
 >  it is failing?
 
 Yep, it fails after linking (when my patch-ag is used)
 --- snip ---
 gcc -o vsftpd main.o utility.o prelogin.o ftpcmdio.o postlogin.o  
 privsock.o  tunables.o ftpdataio.o secbuf.o ls.o  postprivparent.o  
 logging.o str.o netstr.o sysstr.o strlist.o  banner.o filestr.o  
 parseconf.o secutil.o  ascii.o oneprocess.o twoprocess.o privops.o  
 standalone.o hash.o  tcpwrap.o ipaddrparse.o access.o features.o  
 readwrite.o  ssl.o sysutil.o sysdeputil.o -Wl,-s `./vsf_findlibs.sh` - 
 L/usr/pkg/lib -Wl,-R/usr/pkg/lib -lnsl -lsocket
 Undefined                       first referenced
 symbol                             in file
 SSL_load_error_strings              ssl.o
 pam_authenticate                    sysdeputil.o
 SSL_write                           ssl.o
 SSL_CTX_use_PrivateKey_file         ssl.o
 SSL_get_error                       ssl.o
 ERR_error_string                    ssl.o
 pam_start                           sysdeputil.o
 hosts_access                        tcpwrap.o
 pam_close_session                   sysdeputil.o
 ERR_get_error                       ssl.o
 SSL_accept                          ssl.o
 SSLv23_server_method                ssl.o
 pam_end                             sysdeputil.o
 SSL_set_fd                          ssl.o
 RAND_status                         ssl.o
 SSL_free                            ssl.o
 SSL_read                            ssl.o
 SSL_new                             ssl.o
 SSL_CTX_new                         ssl.o
 SSL_get_rbio                        ssl.o
 SSL_get_wbio                        ssl.o
 pam_setcred                         sysdeputil.o
 sock_host                           tcpwrap.o
 SSL_CTX_use_certificate_file        ssl.o
 pam_set_item                        sysdeputil.o
 pam_acct_mgmt                       sysdeputil.o
 SSL_CTX_ctrl                        ssl.o
 request_init                        tcpwrap.o
 BIO_ctrl                            ssl.o
 SSL_CTX_set_cipher_list             ssl.o
 pam_open_session                    sysdeputil.o
 SSL_library_init                    ssl.o
 ld: fatal: Symbol referencing errors. No output written to vsftpd
 collect2: ld returned 1 exit status
 --- snap ---
 
 >> +.endif
 >>
 >>  .include "options.mk"
 >>
 >> diff -uraN ../net/vsftpd/patches/patch-ag vsftpd/patches/patch-ag
 >
 >  I can't comment on the patch itself. Does a variable like timezone or
 >  localtime exist perhaps?
 
 Dunno, but this way does work fine - the only problem is, the tm  
 struct doesn't contain tm_gmtoff.
 
 bye
 
 Stefan
 
 -- 
          http://www.dreamind.de/
 Oroborus and Debian GNU/Linux Developer.