pkg/33679: Courier IMAP SSL rc.d scripts unterminated "'s

[mrboo%bone2.bone.servebeer.com@localhost]

>Number:         33679
>Category:       pkg
>Synopsis:       Courier IMAP SSL rc.d scripts unterminated "'s
>Confidential:   no
>Severity:       critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jun 09 17:05:00 +0000 2006
>Originator:     mark.r.cullen%gmail.com@localhost
>Release:        NetBSD 3.0
>Organization:
        
>Environment:
        
        
System: NetBSD bone2.bone.servebeer.com 3.0 NetBSD 3.0 (BONE) #1: Fri Jun 9 
15:51:51 UTC 2006 
mrboo%bone2.bone.servebeer.com@localhost:/usr/obj/sys/arch/i386/compile/BONE 
i386
Architecture: i386
Machine: i386
>Description:
The SSL specific rc.d scripts installed for the package `mail/courier-imap`, 
from pkgsrc, have a missing terminating " in one of the if statements.
        
>How-To-Repeat:
Install `mail/courier-imap` from pkgsrc and attempt to run the following rc 
scripts:

`/usr/pkg/share/examples/rc.d/courierimaps start`
`/usr/pkg/share/examples/rc.d/courierpops start`
        
>Fix:
This is my first ever attempt at submitting a patch for anything, so I 
apologise if it's in a wrong format or anything.

Patch for: /usr/pkgsrc/mail/courier-imap/files/courierimaps.sh

--- courierimaps.sh     2006-04-30 07:07:07.000000000 +0000
+++ courierimaps.sh.fixed       2006-06-09 16:45:46.000000000 +0000
@@ -41,7 +41,7 @@
                        return 1
                fi
                if [ ! -f "$f" ] && \
-                  [ "$f" = "@PKG_SYSCONFDIR@/imapd.pem ]; then
+                  [ "$f" = "@PKG_SYSCONFDIR@/imapd.pem" ]; then
                        @ECHO@ "Generating IMAP SSL certificate in $f."
                        @PREFIX@/sbin/mkimapdcert >/dev/null 2>&1
                fi

Patch for: /usr/pkgsrc/mail/courier-imap/files/courierpops.sh

--- courierpops.sh      2006-04-30 07:07:07.000000000 +0000
+++ courierpops.sh.fixed        2006-06-09 16:46:00.000000000 +0000
@@ -41,7 +41,7 @@
                        return 1
                fi
                if [ ! -f "$f" ] && \
-                  [ "$f" = "@PKG_SYSCONFDIR@/pop3d.pem ]; then
+                  [ "$f" = "@PKG_SYSCONFDIR@/pop3d.pem" ]; then
                        @ECHO@ "Generating POP3 SSL certificate in $f."
                        @PREFIX@/sbin/mkpop3dcert >/dev/null 2>&1
                fi

        

>Unformatted: