Re: pkg/33804: error in pkgsrc/lang/python23

[Gilles Dauphin <Gilles.Dauphin%enst.fr@localhost>]

The following reply was made to PR pkg/33804; it has been noted by GNATS.

From: Gilles Dauphin <Gilles.Dauphin%enst.fr@localhost>
To: pkg-manager%NetBSD.org@localhost, gnats-admin%NetBSD.org@localhost,
        gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/33804: error in pkgsrc/lang/python23
Date: Fri, 23 Jun 2006 15:33:44 +0200 (CEST)

 > From: tannert%mis.mpg.de@localhost
 > SunOS 5.10 Generic_118833-03 sun4u sparc SUNW,Sun-Fire-V240
 > >Description:
 > cc -c -fno-strict-aliasing -DNDEBUG -O -I/usr/include 
 -I/opt/pkgsrc/130606devel/include/db4 -I/opt/pkgsrc/130606devel/include 
 -I/usr/include -I/opt/pkgsrc/130606devel/include/db4 
 -I/opt/pkgsrc/130606devel/include -I/usr/include 
 -I/opt/pkgsrc/130606devel/include/db4 -I/opt/pkgsrc/130606devel/include -I. 
 -I./Include -fPIC -DPy_BUILD_CORE -o Objects/complexobject.o 
 Objects/complexobject.c
 > Objects/complexobject.c: In function `complex_pow':
 > Objects/complexobject.c:469: error: invalid operands to binary ==
 > Objects/complexobject.c:469: error: wrong type argument to unary minus
 > Objects/complexobject.c:469: error: invalid operands to binary ==
 > Objects/complexobject.c:469: error: wrong type argument to unary minus
 > *** Error code 1
 > >How-To-Repeat:
 > bmake
 > >Fix:
 > Until now no fix.
 
 Long time ago I propose this patch
 --------------------------------------------
 [root@u2 1785] diff -bu Makefile.common.orig Makefile.common
 --- Makefile.common.orig        Tue Jun 20 19:09:41 2006
 +++ Makefile.common     Thu Jun 22 15:34:25 2006
 @@ -29,6 +29,14 @@
  
  .include "../../mk/bsd.prefs.mk"
  
 +.if ${OPSYS} == "SunOS" && ${CC} == "gcc"
 +# workaround for bug in Solaris 8,9,10 , HUGE_VAL is a function in some 
case...
 +#
 +CONFIGURE_ARGS+=       OPT=${CFLAGS:M*:Q}" -D\"Py_HUGE_VAL=HUGE_VAL()\""
 +.else
 +CONFIGURE_ARGS+=       OPT=${CFLAGS:M*:Q}
 +.endif
 +
  PLIST_SRC=     ${.CURDIR}/../../lang/python23/PLIST.common
  .if exists(${.CURDIR}/../../lang/python23/PLIST.${OPSYS})
  PLIST_SRC+=    ${.CURDIR}/../../lang/python23/PLIST.${OPSYS}
 [root@u2 1786] 
 -------------------------------------------
 Gilles