Subject: Re: pkg/33813: multimedia/xine-lib - some files in PLIST are not present on Solaris 10
To: None <solaris-pkg-people@NetBSD.org, gnats-admin@netbsd.org,>
From: Mark Davies <mark@mcs.vuw.ac.nz>
List: pkgsrc-bugs
Date: 06/26/2006 11:50:03
The following reply was made to PR pkg/33813; it has been noted by GNATS.
From: Mark Davies <mark@mcs.vuw.ac.nz>
To: Raymond Meyer <raymond.meyer@rambler.ru>, gnats-bugs@netbsd.org,
joerg@britannica.bec.de
Cc:
Subject: Re: pkg/33813: multimedia/xine-lib - some files in PLIST are not present on Solaris 10
Date: Mon, 26 Jun 2006 23:45:21 +1200
On Monday 26 June 2006 22:26, you wrote:
> Could this be a problem? I think the compiler command above is missing
> -liconv argument. What's the proper way of fixing this?
Yes thats the problem, I have the following patch to the SDL package that
fixes it here. Note the first part of the patch is not directly relevant but
fixes another issue with Solaris on i386.
Index: Makefile
===================================================================
RCS file: /src/cvs/netbsd/pkgsrc/devel/SDL/Makefile,v
retrieving revision 1.65
diff -u -r1.65 Makefile
--- Makefile 15 Jun 2006 09:45:05 -0000 1.65
+++ Makefile 24 Jun 2006 22:11:22 -0000
@@ -19,11 +19,13 @@
.include "../../mk/bsd.prefs.mk"
-.if ${MACHINE_ARCH} == "i386"
+.if ${MACHINE_ARCH} == "i386" && ${OPSYS} != "SunOS"
. include "../../devel/binutils/buildlink3.mk"
BUILD_DEPENDS+= nasm>=0.98:../../devel/nasm
NASMFLAGS_ELF= -f elf
NASMFLAGS_a.out= -f aoutb
+.else
+CONFIGURE_ARGS+= --disable-nasm
.endif
CONFIGURE_ARGS+= --enable-dlopen
@@ -35,6 +37,7 @@
# are noted correctly in the generated sdl-config.
#
CONFIGURE_ENV+= SYSTEM_LIBS=${LDFLAGS:M*:Q}
+LDFLAGS+= ${BUILDLINK_LDADD.iconv}
# buildlink passthru the directories required for the Cocoa framework
# on Darwin if they exist.
cheers
mark