pkg/33919: graphics/glitz 0.5.6 Solaris gcc Sun ld

["Gilles Dauphin" <dauphin%enst.fr@localhost>]

>Number:         33919
>Category:       pkg
>Synopsis:       graphics/glitz 0.5.6 Solaris gcc Sun ld
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Jul 04 20:50:00 +0000 2006
>Originator:     Gilles Dauphin
>Release:        SunOS 5.10 i86pc
>Organization:
ENST 
>Environment:


System: SunOS bi.enst.fr 5.10 Generic_Patch_118844-30 i86pc


>Description:


 gcc -DHAVE_CONFIG_H -I. -I.. -I/pkg/obj/graphics/glitz/work/.buildlink/include 
-DGLX_GLXEXT_LEGACY -O -Wall -Wpointer-arith -Wstrict-prototypes 
-Wmissing-prototypes -Wmissing-declarations -Wnested-externs 
-fno-strict-aliasing -MT glitz_filter.lo -MD -MP -MF .deps/glitz_filter.Tpo -c 
glitz_filter.c  -fPIC -DPIC -o .libs/glitz_filter.o
glitz_filter.c: In function `glitz_filter_set_params':
glitz_filter.c:370: warning: visibility attribute not supported in this 
configuration; ignored
glitz_filter.c: In function `glitz_filter_get_fragment_program':
glitz_filter.c:382: warning: visibility attribute not supported in this 
configuration; ignored
glitz_filter.c: In function `glitz_filter_set_type':
glitz_filter.c:439: warning: visibility attribute not supported in this 
configuration; ignored
glitz_filter.c: In function `glitz_filter_enable':
glitz_filter.c:520: warning: visibility attribute not supported in this 
configuration; ignored
 gcc -DHAVE_CONFIG_H -I. -I.. -I/pkg/obj/graphics/glitz/work/.buildlink/include 
-DGLX_GLXEXT_LEGACY -O -Wall -Wpointer-arith -Wstrict-prototypes 
-Wmissing-prototypes -Wmissing-declarations -Wnested-externs 
-fno-strict-aliasing -MT glitz_filter.lo -MD -MP -MF .deps/glitz_filter.Tpo -c 
glitz_filter.c -o glitz_filter.o >/dev/null 2>&1
/bin/bash ../libtool --tag=CC --mode=link gcc  -O -I/usr/pkg/include 
-DGLX_GLXEXT_LEGACY -I/usr/include -Wall -Wpointer-arith -Wstrict-prototypes 
-Wmissing-prototypes -Wmissing-declarations -Wnested-externs 
-fno-strict-aliasing   -Wl,-R/usr/pkg/lib -L/usr/openwin/lib/64 
-Wl,-R/usr/openwin/lib/64 -o libglitz.la -rpath /usr/pkg/lib -version-info 
1:0:0 -no-undefined  glitz.lo glitz_operator.lo glitz_drawable.lo  
glitz_surface.lo glitz_texture.lo glitz_rect.lo  glitz_status.lo glitz_util.lo 
glitz_region.lo glitz_format.lo  glitz_program.lo glitz_compose.lo 
glitz_filter.lo  glitz_buffer.lo glitz_geometry.lo glitz_pixel.lo glitz_trap.lo 
 glitz_framebuffer.lo glitz_context.lo -lm 
gcc -shared -Wl,-h -Wl,libglitz.so.1 -o .libs/libglitz.so.1.0.0  .libs/glitz.o 
.libs/glitz_operator.o .libs/glitz_drawable.o .libs/glitz_surface.o 
.libs/glitz_texture.o .libs/glitz_rect.o .libs/glitz_status.o 
.libs/glitz_util.o .libs/glitz_region.o .libs/glitz_format.o 
.libs/glitz_program.o .libs/glitz_compose.o .libs/glitz_filter.o 
.libs/glitz_buffer.o .libs/glitz_geometry.o .libs/glitz_pixel.o 
.libs/glitz_trap.o .libs/glitz_framebuffer.o .libs/glitz_context.o  
-L/pkg/obj/graphics/glitz/work/.x11-buildlink/lib/64 -lm 
-L/pkg/obj/graphics/glitz/work/.buildlink/lib -lc  -Wl,-R/usr/pkg/lib 
-Wl,-R/usr/openwin/lib/64
Text relocation remains                         referenced
    against symbol                  offset      in file
glitz_composite_op_init             0x11c       .libs/glitz.o
glitz_surface_status_add            0x132       .libs/glitz.o
glitz_surface_status_add            0x1df       .libs/glitz.o
glitz_surface_status_add            0xd42       .libs/glitz.o
glitz_surface_status_add            0x1200      .libs/glitz.o
glitz_surface_status_add            0x8d1       .libs/glitz_surface.o
....
glitz_filter_get_fragment_program   0x14a7      .libs/glitz_compose.o
glitz_buffer_unbind                 0x6c7       .libs/glitz_geometry.o
glitz_buffer_unbind                 0x2589      .libs/glitz_pixel.o
glitz_buffer_unbind                 0x3594      .libs/glitz_pixel.o
INT_glitz_context_make_current      0x1ef       .libs/glitz_context.o
ld: fatal: relocations remain against allocatable but non-writable sections
collect2: ld returned 1 exit status
*** Error code 1
make: Fatal error: Command failed for target `libglitz.la'
Current working directory /pkg/obj/graphics/glitz/work/glitz-0.5.6/src
*** Error code 1



>How-To-Repeat:


bmake in graphics/glitz


>Fix:


because the Solaris gcc use the Sun ld 
the attribute hidden is not autorized.
and linker protest when compiling with PIC option.
patch for glitzint.h is needed for Solaris and can be apply to all Solaris
system. The matter of 'hidden attribute' is to win ONE memory access!!


--- src/glitzint.h.orig Mon Mar 13 14:43:57 2006
+++ src/glitzint.h      Tue Jul  4 19:13:55 2006
@@ -69,7 +69,7 @@
 # define sqrtf(a)     sqrt (a)
 #endif
 
-#if __GNUC__ >= 3 && defined(__ELF__)
+#if __GNUC__ >= 3 && defined(__ELF__) && !defined(__sun__)
 # define slim_hidden_proto(name)       slim_hidden_proto1(name, INT_##name)
 # define slim_hidden_def(name)         slim_hidden_def1(name, INT_##name)
 # define slim_hidden_proto1(name, internal)                            \
@@ -89,7 +89,7 @@
 # define slim_hidden_def(name)
 #endif
 
-#if (__GNUC__ > 3 || (__GNUC__ == 3 && __GNUC_MINOR__ >= 3)) && 
defined(__ELF__)
+#if (__GNUC__ > 3 || (__GNUC__ == 3 && __GNUC_MINOR__ >= 3)) && 
defined(__ELF__) && !defined
(__sun__)
 #define __internal_linkage     __attribute__((__visibility__("hidden")))
 #else
 #define __internal_linkage