Re: pkg/33930: net/netcat6 failes to build with gcc 4

[Jukka Salmi <j+nbsd%2006.salmi.ch@localhost>]

The following reply was made to PR pkg/33930; it has been noted by GNATS.

From: Jukka Salmi <j+nbsd%2006.salmi.ch@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: ghen%NetBSD.org@localhost
Subject: Re: pkg/33930: net/netcat6 failes to build with gcc 4
Date: Thu, 6 Jul 2006 21:08:12 +0200

 --xHFwDpU9dbj6ez1V
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 It's probably best to solve this problem the same way as many other
 tools do: define alloca to __builtin_alloca if using gcc.
 
 
 Cheers, Jukka
 
 -- 
 bashian roulette:
 $ ((RANDOM%6)) || rm -rf ~
 
 --xHFwDpU9dbj6ez1V
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="nc6_alloca.patch"
 
 Index: net/netcat6/distinfo
 ===================================================================
 RCS file: /cvsroot/pkgsrc/net/netcat6/distinfo,v
 retrieving revision 1.3
 diff -u -p -r1.3 distinfo
 --- net/netcat6/distinfo       14 Mar 2006 01:42:55 -0000      1.3
 +++ net/netcat6/distinfo       6 Jul 2006 18:53:53 -0000
 @@ -3,4 +3,4 @@ $NetBSD: distinfo,v 1.3 2006/03/14 01:42
  SHA1 (nc6-1.0.tar.bz2) = 1c361a8060be427fe1b2209d7155e26670e0c1b9
  RMD160 (nc6-1.0.tar.bz2) = c5444976925ffece7f27fc1ff3c16ebe19998b78
  Size (nc6-1.0.tar.bz2) = 264257 bytes
 -SHA1 (patch-aa) = 7f1f6df170d57cdb518138af7644a34cd93d1c62
 +SHA1 (patch-aa) = 77cd0084c0be48bcbcbfd2a96f08f430eea68650
 Index: net/netcat6/patches/patch-aa
 ===================================================================
 RCS file: /cvsroot/pkgsrc/net/netcat6/patches/patch-aa,v
 retrieving revision 1.3
 diff -u -p -r1.3 patch-aa
 --- net/netcat6/patches/patch-aa       14 Mar 2006 01:42:55 -0000      1.3
 +++ net/netcat6/patches/patch-aa       6 Jul 2006 18:53:53 -0000
 @@ -1,13 +1,22 @@
  $NetBSD: patch-aa,v 1.3 2006/03/14 01:42:55 joerg Exp $
  
 ---- src/netsupport.c.orig     2006-03-14 01:33:01.000000000 +0000
 -+++ src/netsupport.c
 -@@ -38,7 +38,7 @@
 - #ifdef _AIX
 - #pragma alloca
 +--- src/netsupport.c.orig     2006-01-19 23:46:23.000000000 +0100
 ++++ src/netsupport.c  2006-07-06 20:48:20.000000000 +0200
 +@@ -32,6 +32,9 @@
 + #include <sys/socket.h>
 + #include <netinet/in.h>
 + 
 ++#ifdef __GNUC__
 ++#define alloca __builtin_alloca
 ++#else
 + #if HAVE_ALLOCA_H
 + #include <alloca.h>
   #else
 --#ifndef alloca /* predefined by HP cc +Olibcalls */
 -+#if !defined(alloca) && !defined(__DragonFly__) && !defined(__FreeBSD__)
 - char *alloca();
 +@@ -43,6 +46,7 @@ char *alloca();
   #endif
   #endif
 + #endif
 ++#endif
 + 
 + RCSID("@(#) $Header: /ds6/cvs/nc6/src/netsupport.c,v 1.14 2006/01/19 
22:46:23 chris Exp $");
 + 
 
 --xHFwDpU9dbj6ez1V--