Re: pkg/34337: [update] sysutils/file

[Martin Wilke <netbsd%unixfreunde.de@localhost>]

The following reply was made to PR pkg/34337; it has been noted by GNATS.

From: Martin Wilke <netbsd%unixfreunde.de@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: joerg%britannica.bec.de@localhost, pkg-manager%netbsd.org@localhost,
        gnats-admin%netbsd.org@localhost, pkgsrc-bugs%netbsd.org@localhost,
        "Martin Wilke" <miwi%FreeBSD.org@localhost>
Subject: Re: pkg/34337: [update] sysutils/file
Date: Tue, 29 Aug 2006 17:51:32 +0200

 On Tue, 29 Aug 2006 15:15:18 +0000 (UTC)
 Joerg Sonnenberger <joerg%britannica.bec.de@localhost> wrote:
 
 > The following reply was made to PR pkg/34337; it has been noted by
 > GNATS.
 > 
 > From: Joerg Sonnenberger <joerg%britannica.bec.de@localhost>
 > To: gnats-bugs%NetBSD.org@localhost
 > Cc: 
 > Subject: Re: pkg/34337: [update] sysutils/file
 > Date: Tue, 29 Aug 2006 17:12:42 +0200
 > 
 >  On Tue, Aug 29, 2006 at 02:55:07PM +0000, Martin Wilke wrote:
 >  > Index: buildlink3.mk
 >  > ===================================================================
 >  > RCS file: /home/pcvs/pkgsrc/sysutils/file/buildlink3.mk,v
 >  > retrieving revision 1.6
 >  > diff -u -r1.6 buildlink3.mk
 >  > --- buildlink3.mk 8 Jul 2006 23:11:08 -0000       1.6
 >  > +++ buildlink3.mk 29 Aug 2006 07:06:21 -0000
 >  > @@ -13,8 +13,8 @@
 >  >  BUILDLINK_ORDER:=        ${BUILDLINK_ORDER} ${BUILDLINK_DEPTH}file
 >  >  
 >  >  .if !empty(FILE_BUILDLINK3_MK:M+)
 >  > -BUILDLINK_API_DEPENDS.file+=     file>=4.09
 >  > -BUILDLINK_ABI_DEPENDS.file+=     file>=4.09nb1
 >  > +BUILDLINK_API_DEPENDS.file+=     file>=4.17
 >  > +BUILDLINK_ABI_DEPENDS.file+=     file>=4.17nb1
 >  >  BUILDLINK_PKGSRCDIR.file?=       ../../sysutils/file
 >  >  .endif   # FILE_BUILDLINK3_MK
 >  >  
 >  
 >  Are you sure that the API *and* ABI changed? To clarify the
 > difference: API_DEPENDS means that the programming interface was
 > changed and most packages are expected to use the new API. When it is
 > only extended in a backward compatible way, it should be left as is.
 >  
 >  ABI_DEPENDS bumps should only occur when e.g. a shared library
 > version changed and means that all depending packages need a bump as
 > well. 
 >  I don't remember either of that required.
 >  
 
 No, the API *and* ABI is not change on the sources, i have misunderstood
 the handbook :(. Sorry 
 
 >  Joerg
 >  
 
 
 >  > Index: patches/patch-aa
 >  > ===================================================================
 >  > RCS file: /home/pcvs/pkgsrc/sysutils/file/patches/patch-aa,v
 >  > retrieving revision 1.2
 >  > diff -u -r1.2 patch-aa
 >  > --- patches/patch-aa      18 Feb 2005 19:39:27 -0000      1.2
 >  > +++ patches/patch-aa      29 Aug 2006 07:00:53 -0000
 >  > @@ -1,21 +1,16 @@
 >  > -$NetBSD: patch-aa,v 1.2 2005/02/18 19:39:27 reed Exp $
 >  > -
 >  > ---- src/Makefile.in.orig 2005-01-07 11:17:26.000000000
 >  > -0800 -+++ src/Makefile.in
 >  > -@@ -84,14 +84,14 @@ am__include = @am__include@
 >  > - am__quote = @am__quote@
 >  > - fsect = @fsect@
 >  > - install_sh = @install_sh@
 >  > +--- src/Makefile.in.orig 2006-03-02 23:09:48.000000000
 >  > +0100 ++++ src/Makefile.in        2006-08-29 08:59:39.000000000
 >  > +0200 +@@ -192,11 +192,11 @@
 >  > + sharedstatedir = @sharedstatedir@
 >  > + sysconfdir = @sysconfdir@
 >  > + target_alias = @target_alias@
 >  >  -MAGIC = $(pkgdatadir)/magic
 >  >  +MAGIC = @sysconfdir@/magic
 >  >   lib_LTLIBRARIES = libmagic.la
 >  >   include_HEADERS = magic.h
 >  >   EXTRA_DIST = test.c
 >  > - 
 >  > - bin_PROGRAMS = file
 >  > - 
 >  >  -AM_CPPFLAGS = -DMAGIC='"$(MAGIC)"'
 >  >  +AM_CPPFLAGS = -DMAGIC='"$(MAGIC):$(pkgdatadir)/magic"'
 >  > - 
 >  >   libmagic_la_SOURCES = magic.c apprentice.c softmagic.c
 >  > ascmagic.c \ compress.c is_tar.c readelf.c print.c fsmagic.c \
 >  > +         funcs.c file.h names.h patchlevel.h readelf.h tar.h
 >  > apptype.c
 >  
 >  Patches should be generated e.g. with pkgtools/pkgdiff.
 >  
 >  Joerg
 >  
 
 
 -- 
 
 Martin Wilke miwi%FreeBSD.org@localhost FreeBSD Commiter