pkg/34444: samba build fails at smbd/server.c

[jason%lucid.net.au@localhost]

>Number:         34444
>Category:       pkg
>Synopsis:       samba build fails at smbd/server.c
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Sep 01 02:25:00 +0000 2006
>Originator:     Jason Lingohr
>Release:        pkgsrc -current
>Organization:
>Environment:
Linux fully 2.4.31 #7 Wed Jul 20 16:40:54 EST 2005 i686 i686 i386 GNU/Linux

>Description:
When trying to build samba-3.0.22nb2, the compilation fails with not being able 
to find popt stuff:

Compiling smbd/server.c
smbd/server.c: In function `main':
smbd/server.c:710: `POPT_ARG_VAL' undeclared (first use in this function)
smbd/server.c:710: (Each undeclared identifier is reported only once
smbd/server.c:710: for each function it appears in.)
smbd/server.c:726: warning: passing arg 3 of `poptGetContext' from incompatible 
pointer type
*** Error code 1

Stop.
bmake: stopped in /data1/netbsd/pkgbuild/net/samba/work/samba-3.0.22/source
*** Error code 1

Stop.
bmake: stopped in /usr/pkgsrc/net/samba
*** Error code 1

Stop.
bmake: stopped in /usr/pkgsrc/net/samba

>How-To-Repeat:
bmake, the build fails.

>Fix:
samba requires popt:

Index: Makefile
===================================================================
RCS file: /netbsd/cvsroot/pkgsrc/net/samba/Makefile,v
retrieving revision 1.162
diff -u -r1.162 Makefile
--- Makefile    11 Jul 2006 07:34:35 -0000      1.162
+++ Makefile    31 Aug 2006 22:56:40 -0000
@@ -65,6 +65,8 @@
 .include "../../devel/readline/buildlink3.mk"
 CONFIGURE_ARGS+=       --with-readline=${BUILDLINK_PREFIX.readline}

+.include "../../devel/popt/buildlink3.mk"
+
 .include "options.mk"

 # Only Linux supports smbmount for mounting a Samba share into the